Skip to content

[Form] Add option separator to ChoiceType to use a custom separator after preferred choices #19410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

[Form] Add option separator to ChoiceType to use a custom separator after preferred choices #19410

merged 1 commit into from
Jan 11, 2024

Conversation

alamirault
Copy link
Contributor

Fix #19400

@alamirault alamirault requested a review from xabbuh as a code owner January 10, 2024 21:10
@carsonbot carsonbot added this to the 7.1 milestone Jan 10, 2024
@javiereguiluz javiereguiluz merged commit 645af3f into symfony:7.1 Jan 11, 2024
@javiereguiluz
Copy link
Member

Thanks Antoine!

While merging I did some tweaks to mention the <hr> separator explicitly as a real example when these two options are useful. See a7f5f30

@alamirault alamirault deleted the feature/19400-customize-choice-separator branch January 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Form] Add option separator to ChoiceType to use a custom separator…
4 participants
@alamirault @javiereguiluz @OskarStark @carsonbot