Add entryExists to EntrypointLookupInterface#167
Open
lcharette wants to merge 2 commits intosymfony:mainfrom
Open
Add entryExists to EntrypointLookupInterface#167lcharette wants to merge 2 commits intosymfony:mainfrom
entryExists to EntrypointLookupInterface#167lcharette wants to merge 2 commits intosymfony:mainfrom
Conversation
Contributor
|
Sorry for the slow reply. Not breaking BC was the reason behind not adding it to the interface, which I agree is a bit awkward. We have two choices: A) Add a 2nd interface as you suggested So, we can't merge this PR - but I'd welcome a PR with either of these approaches. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why it was proposed in #147 not to include
entryExistsinEntrypointLookupInterface, but it doesn't makes sense to test agains't a specific class instead of the interface.In my case, this cause an issue as I cannot use dependence injection on
EntrypointLookupInterfaceand expectentryExiststo be present.If this is not approved, I suggest adding
entryExiststo it's own interface and haveEntrypointLookupimplement both (although you won't fix the dependency injection problem).