fix: nil pointer dereference in handleStopWorkload#507
Merged
joeriddles merged 6 commits intomainfrom Mar 25, 2026
Merged
Conversation
When RequestMany returned an error, the return statement was inside the inner error check instead of the outer one, causing execution to fall through and call the nil msgs callback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Riddle <joe@synadia.com>
Use cmd.Wait() instead of cmd.Process.Wait() to ensure I/O pipe-copying goroutines complete before returning, preventing a race between the exec package's internal goroutine writing to the logger buffer and test code reading it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Riddle <joe@synadia.com>
joeriddles
changed the title
nil pointer dereference in handleStopWorkload
joeriddles
changed the title
nil pointer dereference in handleStopWorkloadhandleStopWorkload
jordan-rash
previously approved these changes
Mar 24, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Riddle <joe@synadia.com>
Signed-off-by: Joe Riddle <joe@synadia.com>
jordan-rash
previously approved these changes
Mar 25, 2026
Signed-off-by: Joe Riddle <joe@synadia.com>
jordan-rash
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RequestMany returned an error, the return statement was inside the inner error check instead of the outer one, causing execution to fall through and call the nil msgs callback.