Skip to content

FileUpdateTask serialize/deserialize mismatch: version field is absent #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firsinanton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FileUpdateTask serialize/deserialize mismatch: version field is absent #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/NAppUpdate.Framework/Tasks/FileUpdateTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ public class FileUpdateTask : UpdateTaskBase
[NauField("sha256-checksum", "SHA-256 checksum to validate the file after download (optional)", false)]
public string Sha256Checksum { get; set; }

[NauField("version", "File version to validate the file after download (optional)", false)]
public string Version { get; set; }

[NauField("hotswap",
"Default update action is a cold update; check here if a hot file swap should be attempted"
, false)]
Expand Down
35 changes: 35 additions & 0 deletions src/NAppUpdate.Tests/FeedReaders/NauXmlFeedReaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,40 @@ public void NauReaderCanReadFeed3()

Assert.AreEqual(64, cnd.OsBits);
}

[TestMethod]
public void NauReaderCanReadFeed4()
{
const string NauUpdateFeed =
@"<?xml version=""1.0"" encoding=""utf-8""?>
<Feed>
<Title>My application</Title>
<Link>http://myapp.com/</Link>
<Tasks>
<FileUpdateTask localPath=""test.dll"" updateTo=""remoteFile.dll"" hotswap=""true"" version=""1.0.0.0"">
<Description>update details</Description>
<Conditions>
<OSCondition bit=""64"" />
</Conditions>
</FileUpdateTask>
</Tasks>
</Feed>";

var reader = new NAppUpdate.Framework.FeedReaders.NauXmlFeedReader();
IList<IUpdateTask> updates = reader.Read(NauUpdateFeed);

Assert.IsTrue(updates.Count == 1);

var task = updates[0] as FileUpdateTask;
Assert.IsNotNull(task);
Assert.IsTrue(task.CanHotSwap);

Assert.AreEqual(1, task.UpdateConditions.ChildConditionsCount);

var cnd = task.UpdateConditions.Degrade() as OSCondition;
Assert.IsNotNull(cnd);

Assert.AreEqual(64, cnd.OsBits);
}
}
}