This repository was archived by the owner on Feb 8, 2026. It is now read-only.
Conversation
44072fe to
23d49c4
Compare
592e398 to
9283cc2
Compare
coreyphillips
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor for bottom-sheets, changes are:
isOpen()method which is needed for timed sheets and also allows us to reference and close any open sheets when navigating to a new screen (instead of doing in manually in each case)Some fixes where needed after refactoring:
Linked Issues/Tasks
Closes https://github.com/synonymdev/bitkit/issues/1635
Type of change
Tests
Screenshot / Video
Can spam open/close sheets:
Simulator.Screen.Recording.-.iPhone.16.-.2025-03-11.at.19.53.41.mp4
QA Notes
Timed bottom sheets and keyboard behavior should be tested thoroughly