fix: return None instead of raw invalid data in invalid_to_none#237
Open
sniper-noob wants to merge 1 commit intosynthdataco:mainfrom
Open
fix: return None instead of raw invalid data in invalid_to_none#237sniper-noob wants to merge 1 commit intosynthdataco:mainfrom
sniper-noob wants to merge 1 commit intosynthdataco:mainfrom
Conversation
The invalid_to_none() WrapValidator was returning the raw invalid value v instead of None when Pydantic validation failed. This defeated the purpose of the function - malformed miner responses passed through unmodified. Example of the bug: # Miner sends: simulation_output = "not_a_tuple" # handler(v) raises ValidationError # Function returned "not_a_tuple" instead of None # This invalid data then flows into DB storage and CRPS workers # With fix: ValidationError -> returns None -> safely handled downstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invalid_to_none() WrapValidator was returning the raw invalid value v instead of None when Pydantic validation failed. This defeated the purpose of the function - malformed miner responses passed through unmodified.
Example of the bug:
Miner sends: simulation_output = "not_a_tuple"
handler(v) raises ValidationError
Function returned "not_a_tuple" instead of None
This invalid data then flows into DB storage and CRPS workers
With fix: ValidationError -> returns None -> safely handled downstream