lint: add ruff linter and fix linter issues

Author: tembleking

.flake8

@@ -34,7 +34,7 @@
 # Return the result
 #
 if ok:
-    if not ("files" in res) or len(res["files"]) == 0:
+    if "files" not in res or len(res["files"]) == 0:
         print("No current auto configuration")
     else:
         print("Current contents of config file:")

examples/get_agents_config.py

@@ -21,6 +21,7 @@
             packages = [
               python310 # Minimum supported python version in this project
               uv
+              ruff
             ];
           };
 

flake.nix

@@ -1,5 +1,6 @@
 import json
 from typing import Any, Tuple, Union
+import re
 
 from sdcclient._common import _SdcCommon
 from sdcclient.monitor import EventsClientV2, DashboardsClientV3

sdcclient/_monitor.py

@@ -157,12 +157,12 @@ def convert_property_name(prop_name, old_metric, new_metric):
             sorted_metrics = []
             timestamp_key = [m for m in migrated_metrics
                              if m['id'] == 'timestamp' and
-                             not ('timeAggregation' in m) or
+                             'timeAggregation' not in m or
                              not (m['timeAggregation'] is not None)
                              ]
             no_timestamp_keys = [m for m in migrated_metrics
                                  if m['id'] != 'timestamp' and
-                                 not ('timeAggregation' in m) or
+                                 'timeAggregation' not in m or
                                  not (m['timeAggregation'] is not None)
                                  ]
             values = [m for m in migrated_metrics

sdcclient/monitor/dashboard_converters/_dashboard_versions.py

@@ -7,7 +7,7 @@
 from expects import expect, have_key, contain
 from expects.matchers import _Or
 from expects.matchers.built_in import have_keys, equal
-from mamba import description, it, before, after
+from mamba import description, it, before, after, _it
 
 from sdcclient import SdMonitorClient
 from specs import be_successful_api_call

specs/monitor/captures_v1_spec.py

@@ -173,7 +173,7 @@ def get_integration_map(acc, channel):
         # delete all PagerDuty notification channels in Sysdig that do NOT have an integration in PagerDuty
         #
         for channel in pager_duty_channels:
-            if not channel['options']['serviceKey'] in service_integration_keys:
+            if channel['options']['serviceKey'] not in service_integration_keys:
                 actions.append({
                     'info': 'Remove notification channel "{}" not connected to any integration'.format(channel['name']),
                     'fn': actions_factory.delete_notification_channel(channel)