lint + static analysis: clang-tidy and cppcheck fixes

.clang-tidy

@@ -0,0 +1,12 @@
+Checks: >
+  clang-analyzer-*,
+  bugprone-*,
+  performance-*,
+  modernize-use-nullptr,
+  modernize-use-override,
+  modernize-loop-convert,
+  modernize-pass-by-value,
+  readability-braces-around-statements
+WarningsAsErrors: ''
+HeaderFilterRegex: 'include/|lib/'
+FormatStyle: none

.gitignore

@@ -1,6 +1,9 @@
 # Internal Repos
 priv-infra/
 
+# Lint output (do not commit)
+lint/
+
 # direnv
 .envrc.local
 

Makefile

@@ -14,6 +14,20 @@ ifndef GIT_VERSION_BASE
     $(error GIT_VERSION_BASE is not set)
 endif
 
+.PHONY: lint lint-generate-cdb lint-run
+
+lint-generate-cdb:
+	@echo "Generating compile_commands.json (requires bear)"
+	./scripts/lint/generate-compile-commands.sh
+
+lint-run:
+	@echo "Running local linters"
+	./scripts/lint/run-local.sh
+
+lint: lint-generate-cdb lint-run
+	@echo "Done lint"
+
+
 ### RELEASE TIERS & FEATURE FLAGS:
 ### ProxySQL supports three distinct release tiers built from the same codebase.
 ### The tier is controlled by environment variables which enable feature guards

include/AI_Features_Manager.h

@@ -27,8 +27,8 @@
  * @endcode
  */
 
-#ifndef __CLASS_AI_FEATURES_MANAGER_H
-#define __CLASS_AI_FEATURES_MANAGER_H
+#ifndef PROXYSQL_AI_FEATURES_MANAGER_H
+#define PROXYSQL_AI_FEATURES_MANAGER_H
 
 #ifdef PROXYSQLGENAI
 

include/AI_Vector_Storage.h

@@ -1,5 +1,5 @@
-#ifndef __CLASS_AI_VECTOR_STORAGE_H
-#define __CLASS_AI_VECTOR_STORAGE_H
+#ifndef PROXYSQL_AI_VECTOR_STORAGE_H
+#define PROXYSQL_AI_VECTOR_STORAGE_H
 
 #ifdef PROXYSQLGENAI
 

include/Anomaly_Detector.h

@@ -32,8 +32,8 @@
  * @endcode
  */
 
-#ifndef __CLASS_ANOMALY_DETECTOR_H
-#define __CLASS_ANOMALY_DETECTOR_H
+#ifndef PROXYSQL_ANOMALY_DETECTOR_H
+#define PROXYSQL_ANOMALY_DETECTOR_H
 
 #ifdef PROXYSQLGENAI
 

include/Base_HostGroups_Manager.h

@@ -347,7 +347,7 @@ class BaseHGC {	// MySQL Host Group Container
 		bool connection_warming;
 		bool configured; // this variable controls if attributes are configured or not. If not configured, they do not apply
 		bool initialized; // this variable controls if attributes were ever configured or not. Used by reset_attributes()
-		nlohmann::json * ignore_session_variables_json = NULL; // the JSON format of ignore_session_variables
+		nlohmann::json * ignore_session_variables_json = nullptr; // the JSON format of ignore_session_variables
 	} attributes;
 	struct {
 		int64_t weight;
@@ -393,7 +393,7 @@ class Group_Replication_Info {
 	char *comment;
 	bool active;
 	int writer_is_also_reader;
-	bool __active;
+	bool active_;
 	bool need_converge; // this is set to true on LOAD MYSQL SERVERS TO RUNTIME . This ensure that checks wil take an action
 	int current_num_writers;
 	int current_num_backup_writers;
@@ -415,7 +415,7 @@ class Galera_Info {
 	char *comment;
 	bool active;
 	int writer_is_also_reader;
-	bool __active;
+	bool active_;
 	bool need_converge; // this is set to true on LOAD MYSQL SERVERS TO RUNTIME . This ensure that checks wil take an action
 	int current_num_writers;
 	int current_num_backup_writers;
@@ -444,7 +444,7 @@ class AWS_Aurora_Info {
 	char * domain_name;
 	char * comment;
 	bool active;
-	bool __active;
+	bool active_;
 	AWS_Aurora_Info(int w, int r, int _port, char *_end_addr, int maxl, int al, int minl, int lnc, int ci, int ct, bool _a, int wiar, int nrw, char *c);
 	bool update(int r, int _port, char *_end_addr, int maxl, int al, int minl, int lnc, int ci, int ct, bool _a, int wiar, int nrw, char *c);
 	~AWS_Aurora_Info();
@@ -482,20 +482,20 @@ struct p_hg_counter {
 		myhgm_myconnpool_reset,
 		myhgm_myconnpool_destroy,
 		auto_increment_delay_multiplex,
-		__size
+		SIZE_
 	};
 };
 
 struct p_hg_gauge {
 	enum metric {
 		server_connections_connected = 0,
 		client_connections_connected,
-		__size
+		SIZE_
 	};
 };
 
 struct p_hg_dyn_counter {
-	enum metric {
+	enum metric : uint8_t {
 		conn_pool_bytes_data_recv = 0,
 		conn_pool_bytes_data_sent,
 		connection_pool_conn_err,
@@ -504,22 +504,22 @@ struct p_hg_dyn_counter {
 		gtid_executed,
 		proxysql_mysql_error,
 		mysql_error,
-		__size
+		SIZE_
 	};
 };
 
-enum class p_mysql_error_type {
+enum class p_mysql_error_type : uint8_t {
 	mysql,
 	proxysql
 };
 
 struct p_hg_dyn_gauge {
-	enum metric {
+	enum metric : uint8_t {
 		connection_pool_conn_free = 0,
 		connection_pool_conn_used,
 		connection_pool_latency_us,
 		connection_pool_status,
-		__size
+		SIZE_
 	};
 };
 
@@ -550,7 +550,7 @@ enum READ_ONLY_SERVER_T {
 	ROS_HOSTNAME = 0,
 	ROS_PORT,
 	ROS_READONLY,
-	ROS__SIZE
+	ROS_SIZE_
 };
 
 enum REPLICATION_LAG_SERVER_T {
@@ -559,7 +559,7 @@ enum REPLICATION_LAG_SERVER_T {
 	RLS_PORT,
 	RLS_CURRENT_REPLICATION_LAG,
 	RLS_OVERRIDE_REPLICATION_LAG,
-	RLS__SIZE
+	RLS_SIZE_
 };
 
 /**
@@ -637,18 +637,18 @@ class MySQL_HostGroups_Manager {
 		MYSQL_SERVERS_SSL_PARAMS,
 		MYSQL_SERVERS,
 
-		__HGM_TABLES_SIZE
+		HGM_TABLES_SIZE_
 	};
 
-	std::array<uint64_t, __HGM_TABLES_SIZE> table_resultset_checksum { {0} };
+	std::array<uint64_t, HGM_TABLES_SIZE_> table_resultset_checksum { {0} };
 
 	class HostGroup_Server_Mapping {
 	public:
 		enum Type {
 			WRITER = 0,
 			READER = 1,
 
-			__TYPE_SIZE
+			TYPE_SIZE_
 		};
 
 		struct Node {
@@ -713,7 +713,7 @@ class MySQL_HostGroups_Manager {
 		MySrvC* insert_HGM(unsigned int hostgroup_id, const MySrvC* srv);
 		void remove_HGM(MySrvC* srv);
 
-		std::array<std::vector<Node>, __TYPE_SIZE> mapping; // index 0 contains reader and 1 contains writer hostgroups
+		std::array<std::vector<Node>, TYPE_SIZE_> mapping; // index 0 contains reader and 1 contains writer hostgroups
 		int readonly_flag;
 		MySQL_HostGroups_Manager* myHGM;
 	};
@@ -915,12 +915,12 @@ class MySQL_HostGroups_Manager {
 		//////////////////////////////////////////////////////
 
 		/// Prometheus metrics arrays
-		std::array<prometheus::Counter*, p_hg_counter::__size> p_counter_array {};
-		std::array<prometheus::Gauge*, p_hg_gauge::__size> p_gauge_array {};
+		std::array<prometheus::Counter*, p_hg_counter::SIZE_> p_counter_array {};
+		std::array<prometheus::Gauge*, p_hg_gauge::SIZE_> p_gauge_array {};
 
 		// Prometheus dyn_metrics families arrays
-		std::array<prometheus::Family<prometheus::Counter>*, p_hg_dyn_counter::__size> p_dyn_counter_array {};
-		std::array<prometheus::Family<prometheus::Gauge>*, p_hg_dyn_gauge::__size> p_dyn_gauge_array {};
+		std::array<prometheus::Family<prometheus::Counter>*, p_hg_dyn_counter::SIZE_> p_dyn_counter_array {};
+		std::array<prometheus::Family<prometheus::Gauge>*, p_hg_dyn_gauge::SIZE_> p_dyn_gauge_array {};
 
 		/// Prometheus connection_pool metrics
 		std::map<std::string, prometheus::Counter*> p_conn_pool_bytes_data_recv_map {};

include/ClickHouse_Authentication.hpp

@@ -20,9 +20,9 @@ typedef struct _ch_account_details_t {
 	bool fast_forward;
 	int max_connections;
 	int num_connections_used;
-	bool __frontend;  // this is used only during the dump
-	bool __backend;   // this is used only during the dump
-	bool __active;
+	bool frontend_;  // this is used only during the dump
+	bool backend_;   // this is used only during the dump
+	bool active_;
 } ch_account_details_t;
 
 struct ch_dup_account_details_t {
@@ -79,7 +79,7 @@ class ClickHouse_Authentication {
 	             bool *fast_forward, int *max_connections, void **sha1_pass);
 	ch_account_details_t lookup(char* username, enum cred_username_type usertype, const ch_dup_account_details_t& dup_details);
 	int dump_all_users(ch_account_details_t ***, bool _complete = true);
-	int increase_frontend_user_connections(char *username, int *mc = NULL);
+	int increase_frontend_user_connections(char *username, int *mc = nullptr);
 	void decrease_frontend_user_connections(char *username);
 	void set_all_inactive(enum cred_username_type usertype);
 	void remove_inactives(enum cred_username_type usertype);

include/Command_Counter.h

@@ -1,5 +1,5 @@
-#ifndef __CLASS_COMMAND_COUNTER_H
-#define __CLASS_COMMAND_COUNTER_H
+#ifndef PROXYSQL_COMMAND_COUNTER_H
+#define PROXYSQL_COMMAND_COUNTER_H
 
 class Command_Counter {
 public:
@@ -60,4 +60,4 @@ class Command_Counter {
 	}
 };
 
-#endif /* __CLASS_COMMAND_COUNTER_H */
+#endif /* PROXYSQL_COMMAND_COUNTER_H */

include/GenAI_Thread.h

@@ -1,5 +1,5 @@
-#ifndef __CLASS_GENAI_THREAD_H
-#define __CLASS_GENAI_THREAD_H
+#ifndef PROXYSQL_GENAI_THREAD_H
+#define PROXYSQL_GENAI_THREAD_H
 
 #ifdef PROXYSQLGENAI
 

include/LLM_Bridge.h

@@ -25,8 +25,8 @@
  * @endcode
  */
 
-#ifndef __CLASS_LLM_BRIDGE_H
-#define __CLASS_LLM_BRIDGE_H
+#ifndef PROXYSQL_LLM_BRIDGE_H
+#define PROXYSQL_LLM_BRIDGE_H
 
 #ifdef PROXYSQLGENAI
 
@@ -334,4 +334,4 @@ class LLM_Bridge {
 
 #endif /* PROXYSQLGENAI */
 
-#endif // __CLASS_LLM_BRIDGE_H
+#endif /* PROXYSQL_LLM_BRIDGE_H */

include/MCP_Thread.h

@@ -1,5 +1,5 @@
-#ifndef __CLASS_MCP_THREAD_H
-#define __CLASS_MCP_THREAD_H
+#ifndef PROXYSQL_MCP_THREAD_H
+#define PROXYSQL_MCP_THREAD_H
 
 #ifdef PROXYSQLGENAI
 

include/MySQL_Authentication.hpp

@@ -1,5 +1,5 @@
-#ifndef __CLASS_MYSQL_AUTHENTICATION_H
-#define __CLASS_MYSQL_AUTHENTICATION_H
+#ifndef PROXYSQL_MYSQL_AUTHENTICATION_H
+#define PROXYSQL_MYSQL_AUTHENTICATION_H
 
 #include "proxysql.h"
 #include "cpp.h"
@@ -22,9 +22,9 @@ typedef struct _account_details_t {
 	int max_connections;
 	int num_connections_used;
 	int num_connections_used_addl_pass;
-	bool __frontend; // this is used only during the dump
-	bool __backend;	 // this is used only during the dump
-	bool __active;
+	bool frontend_; // this is used only during the dump
+	bool backend_;	 // this is used only during the dump
+	bool active_;
 	char *attributes = nullptr;
 	char *comment = nullptr;
 } account_details_t;

include/MySQL_Data_Stream.h

@@ -1,5 +1,5 @@
-#ifndef __CLASS_MYSQL_DATA_STREAM_H
-#define __CLASS_MYSQL_DATA_STREAM_H
+#ifndef PROXYSQL_MYSQL_DATA_STREAM_H
+#define PROXYSQL_MYSQL_DATA_STREAM_H
 
 #include "proxysql.h"
 #include "cpp.h"
@@ -287,4 +287,4 @@ class MySQL_Data_Stream
 
 	void get_client_myds_info_json(nlohmann::json&);
 };
-#endif /* __CLASS_MYSQL_DATA_STREAM_H */
+#endif /* PROXYSQL_MYSQL_DATA_STREAM_H */