ci: revert test workflows to listen on CI-trigger completion#5595
ci: revert test workflows to listen on CI-trigger completion#5595renecannao merged 1 commit intov3.0from
Conversation
Commit 9671a41 changed 32 test workflows to trigger on CI-builds completion instead of CI-trigger completion. This broke PR CI runs: workflow_run-triggered workflows receive the head_sha of the workflow that triggered them, and CI-builds (itself workflow_run-triggered) runs on the default branch with head_sha pointing at v3.0 HEAD rather than the PR commit. As a result, all chained test workflows were checking out and testing v3.0 code instead of PR code. Revert to the original design where test workflows listen on CI-trigger (which is pull_request-triggered and carries the PR head_sha). CI-trigger already contains a babysitter step (gh run watch on CI-builds) that blocks until the build artifacts are ready, so gating on CI-trigger completion still waits for builds. Affects 32 workflow files — only the workflow_run.workflows entry is changed, no other logic touched.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (32)
📜 Recent review details🔇 Additional comments (32)
📝 WalkthroughWalkthroughThis PR updates 27 GitHub Actions workflow files to change their upstream Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
CI-triggercompletion instead ofCI-buildscompletion (as they were before commit 9671a41).v3.0HEAD instead of the PR commit.Root cause
Commit 9671a41 ("ci: comprehensive CI workflow and infrastructure fixes") changed 32 test workflows from:
to:
A
workflow_run-triggered workflow receivesgithub.event.workflow_run.head_shaequal to the SHA of the workflow run that triggered it. SinceCI-buildsis itselfworkflow_run-triggered, it always runs on the default branch (v3.0) with its ownhead_shapointing atv3.0HEAD — not at the PR commit. Chaining the test workflows offCI-buildstherefore caused every test run to check outv3.0code instead of the PR code.Why listening on CI-trigger is safe
CI-triggerispull_request-triggered, so itshead_shais the PR commit. It also contains a babysitter step (gh run watchonCI-builds) that blocks untilCI-buildsfinishes, so test workflows gated onCI-triggercompletion still wait for build artifacts to be ready.Evidence
Before this fix, on PR commits:
CI-triggerran on the PR branch (correcthead_sha).CI-buildsran on default branch withhead_sha = v3.0HEAD.head_shaand tested v3.0 code.Note on testability
This PR itself will not exercise the fix —
workflow_run-triggered workflows always read their YAML from the default branch, so the chained test workflows will continue to use the buggyv3.0version until this PR is merged. The fix will take effect automatically on all open PRs (including new pushes to existing PRs) once merged intov3.0.Test plan
workflows: [ CI-builds ]→workflows: [ CI-trigger ].v3.0.head_sha.Summary by CodeRabbit