ci: fix misleading mysql57 label on ci-mysql84-g{1..5} check runs#5600
ci: fix misleading mysql57 label on ci-mysql84-g{1..5} check runs#5600renecannao merged 1 commit intoGH-Actionsfrom
Conversation
The five ci-mysql84-g*.yml reusables introduced in #5597 inherited `infradb: [ 'mysql57' ]` from ci-legacy-g4.yml as the sed template. The `infradb` matrix value is interpolated into `env.MATRIX` and then into the check-action step's `name` field, so the GitHub PR UI would display check runs as `CI-mysql84-g3 / tests (mysql57)` even though the tests themselves are correctly running against infra-mysql84. The infrastructure resolution is unaffected -- `ensure-infras.bash` strips the -gN suffix from TAP_GROUP=mysql84-g3 to get BASE_GROUP=mysql84, which resolves to test/tap/groups/mysql84/infras.lst (infra-mysql84). This is purely a display-name fix. Set infradb to 'mysql84' in all five files so the check run name matches the backend actually under test. Caught by gemini-code-assist review on #5598.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📜 Recent review details🔇 Additional comments (5)
📝 WalkthroughWalkthroughThis PR updates five CI workflow files to change the test matrix from targeting MySQL 5.7 to MySQL 8.4. Each workflow file has one line modified to update the infrastructure database variant, with no changes to workflow logic, steps, or configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addresses review feedback on #5598: 1. Adds `matrix.infradb` to the "What a sibling differs in" checklist. Gemini-code-assist flagged it -- and it was also a real bug in the merged ci-mysql84-g{1..5}.yml files, fixed in the separate #5600. The doc now explains that `infradb` is cosmetic for routing but displayed in the PR UI via env.MATRIX, so leaving it at the template default creates a misleading "CI-mysql84-g3 / tests (mysql57)" label. 2. Updates the sed example in "Adding a new test group" to substitute the infradb string alongside the group name, so copy-pasting from the doc produces a correct file on the first try. 3. Adds `text` language tag to seven previously untyped fenced code blocks (ASCII diagrams, directory listings, plain-text output) to satisfy markdownlint MD040. CodeRabbit flagged these. The repo doesn't enforce markdownlint, but the tag is harmless and silences the bot for future contributors editing the doc.
|
1 participant
Summary
Five one-line fixes: `infradb: [ 'mysql57' ]` → `infradb: [ 'mysql84' ]` in each of `ci-mysql84-g{1..5}.yml`.
Why
The five `ci-mysql84-g*.yml` reusables introduced in #5597 inherited `infradb: [ 'mysql57' ]` from the `ci-legacy-g4.yml` template I `sed`'d them from. That value is interpolated into `env.MATRIX`:
```yaml
env:
MATRIX: '(${{ matrix.infradb }})'
```
…and `env.MATRIX` is interpolated into the `LouisBrunner/checks-action` step's `name` field:
```yaml
name: '${{ github.workflow }} / ${{ github.job }} ${{ env.MATRIX }}'
```
So on a real mysql84-g3 run the PR UI would display the check as:
```
CI-mysql84-g3 / tests (mysql57) ← misleading
```
…even though the tests themselves are correctly running against `infra-mysql84`. The infrastructure resolution path is unaffected: `ensure-infras.bash` strips the `-gN` suffix from `TAP_GROUP=mysql84-g3` to get `BASE_GROUP=mysql84`, which resolves to `test/tap/groups/mysql84/infras.lst` which lists `infra-mysql84`. The backend is right — only the label was wrong.
Caught by
gemini-code-assist review on #5598 (their inline comment on the sibling-file-cutting documentation). I also updated the docs in a companion commit on #5598 to call out `matrix.infradb` explicitly in the checklist, so future contributors don't repeat the mistake.
Test plan
Files
```
.github/workflows/ci-mysql84-g1.yml
.github/workflows/ci-mysql84-g2.yml
.github/workflows/ci-mysql84-g3.yml
.github/workflows/ci-mysql84-g4.yml
.github/workflows/ci-mysql84-g5.yml
```
Five files, one line changed in each, +5/-5 total.
Summary by CodeRabbit