ci: disable CI-unittests caller temporarily#5604
Conversation
…ger) CI-unittests cannot run in the normal CI cascade right now because the companion PR on GH-Actions (#5603) strips unit test binaries from the _test cache payload to keep it under GitHub's 10 GB per-repo quota. The unit tests are still COMPILED in ci-builds.yml (a sanity check enforces UNIT_COUNT > 0 before stripping, so compile errors in unit tests still fail the build) but their binaries don't ship in the cache, so CI-unittests would fail on "Cache restore test" or on the safety net in proxysql-tester.py that detects zero discovered test binaries. Rather than leave CI-unittests producing confusing red failures on every cascade, remove the workflow_run trigger so it stops firing automatically. The workflow_dispatch trigger is kept so it can still be invoked manually from the Actions tab (e.g. to test a re-enablement branch). This is intentionally the minimum surgical change: - No file deletion (preserves the caller for easy re-enable). - No change to the reusable on GH-Actions (ci-unittests.yml is dormant when no caller invokes it). - An inline comment block at the top of the caller explains the situation and lists the options for re-enabling (docker rebuild, expanded _src cache with incremental make, or artifact plumbing). Re-enabling CI-unittests is a separate follow-up effort. The goal for now is to unblock CI-legacy-g* and CI-mysql84-g* by getting the _test cache under quota; unit tests will come back later with a proper rebuild strategy. Companion PR: #5603
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Final validation of the CI cascade after: - #5603 (GH-Actions): ci-builds.yml strips unit binaries + test/deps from the _test cache to stay under the 10 GB repo quota - #5604 (v3.0): CI-unittests workflow_run trigger removed so it stops firing automatically Expected signals: - CI-builds log shows 'Compiled N unit test binaries' (N>0), then 'Deleted N unit test binaries', then 'test/deps runtime-dependency check passed', then 'Deleted test/deps' - _test cache save size ~1 GB compressed (down from ~4 GB) - CI-legacy-g*, CI-mysql84-g*, CI-basictests get past 'Cache restore test' and actually run their tests for realistic durations (minutes, not seconds-and-fail) - proxysql-tester.py reports PASS N/N with N > 0 - CI-unittests does NOT appear in the cascade (disabled)
1 participant
Summary
Removes the `workflow_run` trigger from `.github/workflows/CI-unittests.yml`, so `CI-unittests` stops firing automatically on every PR/push. Keeps `workflow_dispatch` so it can still be invoked manually.
Inline comment block at the top of the file documents why it's disabled, and lists the three options for re-enabling it later.
Why
Companion PR #5603 on `GH-Actions` strips the unit test binaries from the `_test` cache payload (they're 8.8 GB of 52 binaries at 170 MB each and they blow out GitHub's 10 GB per-repo cache quota when combined with concurrent cascades). Unit tests are still compiled in `ci-builds.yml` — a `UNIT_COUNT > 0` check guards the strip so compile errors still fail the build — but the binaries don't ship in the cache.
`CI-unittests` uses the `SKIP_PROXYSQL` host-only path in `run-tests-isolated.bash`, which expects the unit test binaries to exist on disk after the cache restore. They won't, so the workflow would fail with either:
Either way the result is a consistently red `CI-unittests` on every cascade, which is noise and actively confusing.
Disabling the automatic trigger removes the noise. The workflow file stays in place so re-enabling is a small PR later when we have a rebuild strategy.
Re-enable instructions (inline comment in the caller)
To re-enable `CI-unittests`:
Diff
One file, +32 / -3. Comment block + comment out the `workflow_run:` lines.
Test plan
Out of scope
Summary by CodeRabbit