LED commands

[jackpot51]

Commands will be used by keyboard-configurator in pop-os/keyboard-configurator#22

[ids1024]

With this API, a client can determine if there's a controllable keyboard backlight by checking if the max brightness is non-zero, right?

Is there anyway to determine whether or not RGB color is supported, since some models may have a monochrome backlight?

[jackpot51]

@ids1024 I could adjust the led_get_color command to return a bool for whether the color can be changed, if that works

[jackpot51]

I'm running quite low on EC space on the Launch keyboard so I think it would be best if the keyboard definition said wether it supported color

[ids1024]

so I think it would be best if the keyboard definition said wether it supported color

I suppose that works too, since it's already assumed the configurator includes specifications for different keyboard models.

[ids1024]

Another useful feature here, that I had working through pop-os/system76-power#190 (using inotify), is notification of changes. So the Configurator color and brightness could show changes made through keybindings or other methods.

Though that may complicate the API here too much.

[jackpot51]

@ids1024 we can't really do that without a kernel driver to handle interrupts. I recommend that the configurator polls at a reasonable interval, maybe 1 second?