Skip to content

main: Run events at time intervals #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackpot51 merged 1 commit into from
Dec 3, 2024
Merged

main: Run events at time intervals #486

jackpot51 merged 1 commit into from
Dec 3, 2024

Conversation

@crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Jul 13, 2024 •
edited
Loading

Rewrite the main loop to run all its events at certain intervals of the systick instead of running most on every loop.

  • usbpd_event: Every 4 cycles -> 1ms
  • power_event: Every 4 cycles -> 1ms
  • kbscan_event: Every 4 cycles- > 5ms
  • lid_event: Every 4 cycles -> 500ms
  • board_event: Every cycle -> 1ms
  • kbc_event: Every cycle -> 1ms
  • pmc_event: Every cycle -> 1ms
  • smfi_event: Every cycle -> 1ms
  • battery_event: Every 1000ms

Ref: #209, Time-triggered architecture

@crawfxrd crawfxrd force-pushed the event-intervals branch 3 times, most recently from b57f2ab to 8b3e495 Compare July 15, 2024 18:15
@crawfxrd
main: Run events at time intervals
6438d01 
Rewrite the main loop to run all its events at certain intervals of the
systick instead of running most on every loop.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team November 27, 2024 18:54
@crawfxrd crawfxrd marked this pull request as ready for review November 27, 2024 18:54
leviport
leviport approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on oryp12. Everything seems to still be working nicely.

@jackpot51 jackpot51 merged commit a5e34b5 into master Dec 3, 2024
48 checks passed
@jackpot51 jackpot51 deleted the event-intervals branch December 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@leviport leviport leviport approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crawfxrd @jackpot51 @leviport