kbled: Merge I2C implementations #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference between the I2C implementations is the color channel layout. Introduce two new configs for boards to select which they use. - CONFIG_KBLED_I2C_CH_BGR_PACKED: Channels are in BBB|GGG|RRR format - CONFIG_KBLED_I2C_CH_BGR_MIXED: Channels are in BGR|BGR|BGR format Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Sep 9, 2025
jacobgkau
approved these changes
Sep 9, 2025
Member
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
The sha256sum of ec.rom for oryp5 changed after rebuilding with this commit, but it also wasn't identical after going back to master and building again. I assume something else in the build process means it's non-reproducible.
I tried to flash this on oryp5 this morning and ran into a lot of problems getting a build/install to work on a fresh Pop!_OS 22.04 installation. This will end up getting tested when we do firmware update certification on any affected models, so I don't see a reason to hold the merge up for what looks like a simple change.
Member
Author
|
You must set the version to a constant when building for the binary to be identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference between the I2C implementations is the color channel layout. Introduce two new configs for boards to select which they use.
CONFIG_KBLED_I2C_CH_BGR_PACKED: Channels are inBBB|GGG|RRRformatCONFIG_KBLED_I2C_CH_BGR_MIXED: Channels are inBGR|BGR|BGRformatResulting
ec.rombinary is identical.