Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

added coveralls support #370

Open
nfebe wants to merge 2 commits intosysters:developfrom
nfebe:add-coverage-runs
Open

added coveralls support #370
nfebe wants to merge 2 commits intosysters:developfrom
nfebe:add-coverage-runs

Conversation

@nfebe
Copy link

@nfebe nfebe commented Jul 11, 2018

Signed-off-by: Fenn-25 fenn25.fn@gmail.com

Description

Added coveralls to show coverage reports from using coverage.py

Fixes #366

Type of Change:

  • Quality Assurance

How Has This Been Tested?

Run online

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Signed-off-by: Fenn-25 <fenn25.fn@gmail.com>
.travis.yml Outdated
- "3.6"
install:
- "pip3 install -r requirements.txt"
- "pip install coveralls"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other requirements are installed for python3 (line 8 uses pip3), why are you not installing coveralls for python3 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I will just update the line with pip3 to make everything uniform. However the command is tantamount to pip3 in a python 3 environment.

Signed-off-by: Fenn-25 <fenn25.fn@gmail.com>
Copy link

@MehaKaushik MehaKaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants