change EXTRA_CFLAGS to Kbuild ccflags-y#67
Merged
liulog merged 2 commits intosyswonder:mainfrom Jan 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Makefile to use the Kbuild-standard ccflags-y syntax instead of the deprecated EXTRA_CFLAGS variable. It also includes a minor code refactoring in the driver initialization function and updates the RISC-V toolchain prefix.
Changes:
- Converted
EXTRA_CFLAGStoccflags-yin the Makefile for compiler flags - Updated RISC-V cross-compiler prefix from
riscv64-unknown-linux-gnu-toriscv64-linux-gnu- - Changed
irqvariable scope from function-level to block-level inhvisor_init()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| driver/Makefile | Migrated compiler flags from EXTRA_CFLAGS to ccflags-y and updated RISC-V toolchain prefix |
| driver/hvisor.c | Narrowed scope of irq pointer variable to X86_64-specific block |
Comments suppressed due to low confidence (1)
driver/Makefile:17
- This line still uses the deprecated
EXTRA_CFLAGSvariable. For consistency with the PR's goal of migrating to Kbuild syntax, this should be changed toccflags-y += -DLOONGARCH64.
EXTRA_CFLAGS += -DLOONGARCH64
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
enkerewpo
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ralated to #66 .