Skip to content

Conversation

@liulog
Copy link
Contributor

@liulog liulog commented Jan 16, 2026

Ralated to #66 .

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Makefile to use the Kbuild-standard ccflags-y syntax instead of the deprecated EXTRA_CFLAGS variable. It also includes a minor code refactoring in the driver initialization function and updates the RISC-V toolchain prefix.

Changes:

  • Converted EXTRA_CFLAGS to ccflags-y in the Makefile for compiler flags
  • Updated RISC-V cross-compiler prefix from riscv64-unknown-linux-gnu- to riscv64-linux-gnu-
  • Changed irq variable scope from function-level to block-level in hvisor_init()

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
driver/Makefile Migrated compiler flags from EXTRA_CFLAGS to ccflags-y and updated RISC-V toolchain prefix
driver/hvisor.c Narrowed scope of irq pointer variable to X86_64-specific block
Comments suppressed due to low confidence (1)

driver/Makefile:17

  • This line still uses the deprecated EXTRA_CFLAGS variable. For consistency with the PR's goal of migrating to Kbuild syntax, this should be changed to ccflags-y += -DLOONGARCH64.
	EXTRA_CFLAGS += -DLOONGARCH64

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liulog liulog merged commit 91ca40f into syswonder:main Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants