Skip to content

refactor: rename schema types to include Request suffix and simplify …#17

Merged
syucream merged 1 commit intomainfrom
syucream/schemas-refube
May 31, 2025
Merged

refactor: rename schema types to include Request suffix and simplify …#17
syucream merged 1 commit intomainfrom
syucream/schemas-refube

Conversation

@syucream
Copy link
Copy Markdown
Owner

…JSON response format

@syucream syucream requested a review from Copilot May 31, 2025 12:20
@syucream syucream self-assigned this May 31, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors schema naming to include a "Request" suffix for clarity and simplifies the structure of JSON responses returned by the server.

  • Renamed schema identifiers in src/schemas.ts to consistently include the "Request" suffix.
  • Updated schema references in src/mcp.ts to match the new names.
  • Modified JSON responses to directly stringify data.results instead of wrapping it in an object.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/schemas.ts Renamed and updated schema exports to use the "Request" suffix.
src/mcp.ts Updated schema imports and modified JSON response formatting.
Comments suppressed due to low confidence (1)

src/mcp.ts:143

  • Confirm that 'data' consistently includes a 'results' property. If there is any case where data might not have this property, this change could lead to runtime errors.
text: JSON.stringify(data.results, null, 2),

@syucream syucream merged commit c03b60b into main May 31, 2025
1 check passed
@syucream syucream deleted the syucream/schemas-refube branch May 31, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants