Conversation
|
Hello, sorry for not merging this earlier. Thank you for this PR :) |
|
Ah, but see the problem is that this branch needs to be compatibile with PHP 5.4 :/ I would have to create a minor release for this to be merged. In general, I haven't touched this repository in a long while and I need to do some prep work before that. |
|
This requires PHP 7.1. But both 5.x and 7.x are long EOL, why do we care at this point? Anyone still running those versions in 2025 should be slapped :P ...that said, if you insist, the only way to make it work on all versions is to remove the class type hint altogether. But even if you do that, there is no guarantee this will work in the future (PHP 8.5 is right around the corner). |
|
AFAIK there are people who use it on some educational software which was locked to very old PHP. I had a request from them to keep supporting it. I can create a 3.1 branch and drop the older PHP versions there, but I need to setup the CI again. My Travis account exceeded the free plan so I will either need to start paying or migrate to a different CI. |
|
Resolved in #98 , thanks for the PR anyway :) |
|
@szymach thank you for maintaining this library! |
2 participants
Resolves #94