round scaled numbers because half pixels don't exist#94
Open
chrisvltn wants to merge 1 commit intot3dotgg:mainfrom
Open
round scaled numbers because half pixels don't exist#94chrisvltn wants to merge 1 commit intot3dotgg:mainfrom
chrisvltn wants to merge 1 commit intot3dotgg:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvltn
changed the title
|
a slider bar would be better with a number at the bottom that you can change there too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure you do the following before filing your PR:
pnpm run checkand make sure everything passesAdded
Math.ceilto the displayed scaled resolution, as the user can input a custom scale factor which might generate a non-integer resolution.Math.ceilinstead ofMath.roundbecause after a few tests the browser was always rounding it down, independent of the fraction. Maybe it varies from browser to browser, but still more precise than not showing an integer.Before:
After: