Use label's 'for' attribute rather than prev() when building t3onoff #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
PS ... if I'm supposed to raise PR's against a different branch, just let me know, I'll redo the PR. |
|
Is there still a chance to get this PR merged. It is waiting several years and every time we get an update we have to patch this manually for this to work with the Fabrik Framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, the code breaks any on/off radio fieldset that doesn't have the input before the label. This change uses the 'for' attribute of the label to find the input, rather than relying on the DOM structure using prev().
Note that the existing code already does this in the listener on line 36, so already assumes there is a 'for' property.