Skip to content

Fix network-aware config resolution across read and legacy command paths#6

Merged
SergioChan merged 2 commits intomainfrom
test-coverage-improvements
Apr 2, 2026
Merged

Fix network-aware config resolution across read and legacy command paths#6
SergioChan merged 2 commits intomainfrom
test-coverage-improvements

Conversation

@shrey32
Copy link
Copy Markdown
Collaborator

@shrey32 shrey32 commented Apr 1, 2026

Summary

This PR finishes the network-resolution cleanup so explicit chain labels and runtime network overrides are consistently authoritative across command families.

What changed

  • fixed read paths to resolve transport and RLUSD metadata from the requested network

    • price
    • market
    • top-level tx status
    • top-level tx history
  • fixed XRPL command paths that were still mixing resolved network selection with ambient config

    • xrpl trustline status
    • xrpl pathfind
    • xrpl dex
    • xrpl amm
  • fixed balance reads so explicit labels like ethereum-sepolia and xrpl-testnet use the correct network and chain label in output

  • fixed legacy Curve wrappers to keep venue-specific mainnet routing aligned with the config/public client they use underneath

    • eth swap
    • eth lp
  • cleaned up unit test noise in cli.test.ts

Tests

  • added and expanded regression coverage in:
    • test/unit/network-resolution.test.ts
    • test/unit/eth-swap.test.ts
    • test/unit/eth-lp.test.ts

@SergioChan SergioChan merged commit 5867a53 into main Apr 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants