Fix network-aware config resolution across read and legacy command paths#6
Merged
SergioChan merged 2 commits intomainfrom Apr 2, 2026
Merged
Fix network-aware config resolution across read and legacy command paths#6SergioChan merged 2 commits intomainfrom
SergioChan merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR finishes the network-resolution cleanup so explicit chain labels and runtime network overrides are consistently authoritative across command families.
What changed
fixed read paths to resolve transport and RLUSD metadata from the requested network
pricemarkettx statustx historyfixed XRPL command paths that were still mixing resolved network selection with ambient config
xrpl trustline statusxrpl pathfindxrpl dexxrpl ammfixed
balancereads so explicit labels likeethereum-sepoliaandxrpl-testnetuse the correct network and chain label in outputfixed legacy Curve wrappers to keep venue-specific mainnet routing aligned with the config/public client they use underneath
eth swapeth lpcleaned up unit test noise in
cli.test.tsTests
test/unit/network-resolution.test.tstest/unit/eth-swap.test.tstest/unit/eth-lp.test.ts