Skip to content

Conversation

@tab
Copy link
Owner

@tab tab commented Jan 25, 2026

No description provided.

@tab tab requested a review from Copilot January 25, 2026 15:47
@tab tab self-assigned this Jan 25, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes configuration constants in the codebase for better clarity and maintainability. The constants are now grouped by their logical purpose with descriptive comments, and several constants have been renamed to be more consistent and less redundant.

Changes:

  • Reorganized constants into logical groups (Application metadata, Logging defaults, Concurrency settings, etc.)
  • Renamed DefaultLogLevel and DefaultLogFormat to LogLevel and LogFormat
  • Renamed DefaultProfile to Default for consistency with existing naming
  • Increased MaxWorkers from 3 to 5
  • Updated all references throughout the codebase to use the new constant names

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/config/constants.go Reorganized and renamed configuration constants with improved grouping and documentation
internal/config/config.go Updated references to renamed logging and profile constants
internal/config/config_test.go Updated test assertions to use renamed logging constants
internal/app/runner/workerpool_test.go Updated hardcoded worker count values to reference config.MaxWorkers constant
internal/app/cli/commands.go Updated default profile reference to use renamed constant
internal/app/cli/commands_test.go Updated test cases to use renamed profile constant
internal/app/cli/cli_test.go Updated test cases and mock expectations to use renamed constant
cmd/main_test.go Updated test cases to use renamed profile constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.46%. Comparing base (7947e7c) to head (864073c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          34       34           
  Lines        2584     2584           
=======================================
  Hits         2260     2260           
  Misses        285      285           
  Partials       39       39           
Files with missing lines Coverage Δ
internal/app/cli/commands.go 100.00% <100.00%> (ø)
internal/config/config.go 86.76% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tab tab merged commit 6b25dde into master Jan 25, 2026
5 checks passed
@tab tab deleted the fix/constants branch January 25, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants