feat(config): Add concurrency workers config #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tab
commented
Jan 25, 2026
tab
commented
- Add concurrency: workers setting to config.yaml
- Extend default configuration with concurrency workers
- Validate that concurrency workers > 0 in config validation
- Add concurrency: workers setting to config.yaml - Extend default configuration with concurrency workers - Validate that concurrency workers > 0 in config validation
There was a problem hiding this comment.
Pull request overview
This PR adds configurable concurrency worker settings to the application's configuration system. Users can now specify the number of concurrent workers in fuku.yaml, with validation ensuring the value is greater than zero.
Changes:
- Added
concurrency.workersconfiguration field with validation - Updated
WorkerPoolto use configured worker count instead of hardcoded constant - Enhanced test coverage for concurrency configuration loading and validation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/config/config.go | Added Concurrency struct with Workers field, validation logic, and default initialization |
| internal/config/config_test.go | Added comprehensive tests for concurrency configuration validation and loading |
| internal/app/runner/workerpool.go | Modified NewWorkerPool to accept Config parameter and use configured worker count |
| internal/app/runner/workerpool_test.go | Updated tests to use configured workers from Config instead of constant |
| internal/app/errors/errors.go | Added ErrInvalidConcurrencyWorkers error and errors.Is export |
| fuku.yaml | Added example concurrency configuration with 10 workers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 87.46% 87.57% +0.11%
==========================================
Files 34 34
Lines 2584 2591 +7
==========================================
+ Hits 2260 2269 +9
+ Misses 285 284 -1
+ Partials 39 38 -1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.