Skip to content

Conversation

@tab
Copy link
Owner

@tab tab commented Jan 25, 2026

  • Extend Config struct to include Logs.Buffer
  • Update default configuration to set Logs.Buffer
  • Modify hub and server to use the new buffer size

- Extend Config struct to include Logs.Buffer
- Update default configuration to set Logs.Buffer
- Modify hub and server to use the new buffer size
@tab tab requested a review from Copilot January 25, 2026 18:55
@tab tab self-assigned this Jan 25, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configurable logs buffer size support to the application. Previously, the logs buffer size was hardcoded; now it can be configured via the YAML configuration file.

Changes:

  • Added a new Logs.Buffer configuration field with validation
  • Renamed the constant from LogsBufferSize to SocketLogsBufferSize for clarity
  • Updated the hub and server implementations to use the configurable buffer size

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/config/constants.go Renamed constant from LogsBufferSize to SocketLogsBufferSize
internal/config/config_test.go Added tests for logs buffer configuration loading and validation
internal/config/config.go Added Logs struct with Buffer field and validation logic
internal/app/runtime/events_test.go Reformatted test code for consistency
internal/app/runtime/commands_test.go Reformatted test code for consistency
internal/app/runner/runner_test.go Reformatted test code for consistency
internal/app/runner/runner.go Updated NewServer call to pass config
internal/app/logs/server_test.go Updated tests to use config-based buffer size
internal/app/logs/server.go Modified to accept and use config for buffer size
internal/app/logs/protocol_test.go Reformatted test table for better readability
internal/app/logs/hub_test.go Updated tests to pass config and use config-based buffer size
internal/app/logs/hub_mock.go Added NewClientConn mock method
internal/app/logs/hub.go Refactored to use config-based buffer size throughout
internal/app/logs/client_test.go Restructured tests into table-driven format
internal/app/errors/errors.go Added ErrInvalidLogsBuffer error
fuku.yaml Added example logs buffer configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.66%. Comparing base (a05fbe9) to head (40e7148).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   87.62%   87.66%   +0.04%     
==========================================
  Files          34       34              
  Lines        2601     2610       +9     
==========================================
+ Hits         2279     2288       +9     
  Misses        284      284              
  Partials       38       38              
Files with missing lines Coverage Δ
internal/app/logs/hub.go 98.48% <100.00%> (+0.02%) ⬆️
internal/app/logs/server.go 83.96% <100.00%> (+0.15%) ⬆️
internal/app/runner/runner.go 97.10% <100.00%> (ø)
internal/config/config.go 90.00% <100.00%> (+0.45%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tab tab force-pushed the feature/logs-configuration branch from ebfd345 to b91d110 Compare January 25, 2026 19:02
@tab tab force-pushed the feature/logs-configuration branch from b91d110 to 40e7148 Compare January 25, 2026 19:16
@tab tab requested a review from Copilot January 25, 2026 19:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tab tab merged commit 540db67 into master Jan 25, 2026
5 checks passed
@tab tab deleted the feature/logs-configuration branch January 25, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants