-
Notifications
You must be signed in to change notification settings - Fork 0
feat(config): Add logs buffer size config #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tab
commented
Jan 25, 2026
- Extend Config struct to include Logs.Buffer
- Update default configuration to set Logs.Buffer
- Modify hub and server to use the new buffer size
- Extend Config struct to include Logs.Buffer - Update default configuration to set Logs.Buffer - Modify hub and server to use the new buffer size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds configurable logs buffer size support to the application. Previously, the logs buffer size was hardcoded; now it can be configured via the YAML configuration file.
Changes:
- Added a new
Logs.Bufferconfiguration field with validation - Renamed the constant from
LogsBufferSizetoSocketLogsBufferSizefor clarity - Updated the hub and server implementations to use the configurable buffer size
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/config/constants.go | Renamed constant from LogsBufferSize to SocketLogsBufferSize |
| internal/config/config_test.go | Added tests for logs buffer configuration loading and validation |
| internal/config/config.go | Added Logs struct with Buffer field and validation logic |
| internal/app/runtime/events_test.go | Reformatted test code for consistency |
| internal/app/runtime/commands_test.go | Reformatted test code for consistency |
| internal/app/runner/runner_test.go | Reformatted test code for consistency |
| internal/app/runner/runner.go | Updated NewServer call to pass config |
| internal/app/logs/server_test.go | Updated tests to use config-based buffer size |
| internal/app/logs/server.go | Modified to accept and use config for buffer size |
| internal/app/logs/protocol_test.go | Reformatted test table for better readability |
| internal/app/logs/hub_test.go | Updated tests to pass config and use config-based buffer size |
| internal/app/logs/hub_mock.go | Added NewClientConn mock method |
| internal/app/logs/hub.go | Refactored to use config-based buffer size throughout |
| internal/app/logs/client_test.go | Restructured tests into table-driven format |
| internal/app/errors/errors.go | Added ErrInvalidLogsBuffer error |
| fuku.yaml | Added example logs buffer configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 87.62% 87.66% +0.04%
==========================================
Files 34 34
Lines 2601 2610 +9
==========================================
+ Hits 2279 2288 +9
Misses 284 284
Partials 38 38
🚀 New features to boost your workflow:
|
ebfd345 to
b91d110
Compare
b91d110 to
40e7148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.