Open
Conversation
ca4cb04 to
89556d2
Compare
43f3b07 to
fef5d0b
Compare
…g banner support. Added and updated tests.
…g banner support. Added and updated tests.
fef5d0b to
15ad62f
Compare
Pull Request Test Coverage Report for Build 21592354964Details
💛 - Coveralls |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…id#14399) * Fix slot name detection to use best practices * Post review commit * Linter fix * Last post review commit List of concerned names managed | adUnitCode | Résultat | | ---------------------------------- | ---------------- | | `div-gpt-ad-article_top_123456` | `article_top` | | `div-gpt-ad-sidebar-1678459238475` | `sidebar` | | `div-gpt-ad-topbanner-1` | `topbanner-1` ✅ | | `div-gpt-ad-topbanner-2` | `topbanner-2` ✅ | | `sidebar-123456` | `sidebar-123456` | | `article_bottom` | `article_bottom` | * Only normalize GPT codes, leave others unchanged * Add tests on FIX and missing code coverage
… activity checks to get stuck in an infinite loop (prebid#14366) * realTimeData: fix bug where setting circular references in FPD causes activity checks to get stuck in an infinite loop * handle circular references in unguarded properties * prefer allowing more data over avoiding leaks * more edge cases
Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Core: loading external scripts linting rule * using default rule instead of custom * fixing overwritten event/adLoader rule * change to no-restricted-syntax * no-restricted-imports --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* SBE-2291 Remove protected audience related test code * SBE-2291 Remove protected audience related code
…ity tracking logic (prebid#14372) * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic
…handling (prebid#14362) * - Migrated to TypeScript - Removed hardcoded token injection into ortb2Fragments and delegate to the HUMAN implementation, enabling management of which bidders receive tokens and enhancing monitoring and control of latency and performance - Introduce a cached implementation reference via getImpl() - Add module version query parameter when loading the implementation script - Wire onAuctionInitEvent so the implementation can collect QoS, telemetry and statistics per auction * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * - validate module version parameter in script URL - add HumanSecurityImpl interface --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* WURFL RTD: update module documentation * WURFL RTD: update module documentation
* Page view ID. * Page view ID. * Removed console.log. * Removed unused import. * Improved example. * Fixed some tests. * Kobler bid adapter: pass adunitcode in bid request.
…side friendly iframes (prebid#14414) * percentInView: fix bug where viewability calculation is inaccurate inside friendly iframes * use boundingClientRect
* initial commit * storeSplits method * unit tests * remove test * removing storing & extract merging ortb2 * lint * adding default handling * lint * merge fpd cache * review fixes * refactoring, bug fixing, tests * lint * extending bidPrice schema function * removing invalid example * session random * rename * module name * random per auction * modifies some schema function to return value instead of condition result * extra schema evaluators * json fix * evaluating rules per auction * evaluating rules per auction * static config * auctionId * safe guards * registering activities only once * expose configuration type; update integ example rules json URL * evaluating rules fix * fixing model group selection --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
- Added email address to the main description - Added 'cur' parameter to the parameters list - Minor changes in the Adunit config examples
* TeqBlazeSalesAgent Bid Adapter: initial release * update doc --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps and [minimatch](https://github.com/isaacs/minimatch). These dependencies needed to be updated together. Updates `minimatch` from 3.1.2 to 3.1.4 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) Updates `minimatch` from 9.0.5 to 9.0.7 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) Updates `minimatch` from 5.1.6 to 5.1.8 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) Updates `minimatch` from 9.0.4 to 9.0.7 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) Updates `minimatch` from 10.0.3 to 10.2.3 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.4 dependency-type: indirect - dependency-name: minimatch dependency-version: 9.0.7 dependency-type: indirect - dependency-name: minimatch dependency-version: 5.1.8 dependency-type: indirect - dependency-name: minimatch dependency-version: 9.0.7 dependency-type: indirect - dependency-name: minimatch dependency-version: 10.2.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.0.5 to 5.2.0. - [Release notes](https://github.com/patrickjuchli/basic-ftp/releases) - [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md) - [Commits](patrickjuchli/basic-ftp@v5.0.5...v5.2.0) --- updated-dependencies: - dependency-name: basic-ftp dependency-version: 5.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
prebid#14295) * Chrome AI RTD Provider: fix QuotaExceededError with large page content Added MAX_TEXT_LENGTH constant (1000 chars) and text truncation logic in getPageText() to prevent QuotaExceededError when Chrome AI APIs process pages with large amounts of text content. Without this fix, pages with extensive text content can cause the Chrome AI APIs (LanguageDetector, Summarizer) to throw QuotaExceededError exceptions. * Chrome AI RTD Provider: add unit tests for MAX_TEXT_LENGTH and text truncation Adds tests covering: - MAX_TEXT_LENGTH constant exists and equals 1000 - getPageText returns null for text below MIN_TEXT_LENGTH - getPageText returns null for empty text - getPageText returns full text when between MIN and MAX length - getPageText does not truncate text at exactly MAX_TEXT_LENGTH - getPageText truncates text exceeding MAX_TEXT_LENGTH - getPageText logs a message when truncating Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Paul Farrow <paul.farrow@xandr.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ebid#14323) * feat: add live display and access examples of Neuwo API data to example page * feat: add Prebid.js event timing tests to Neuwo RTD example page * style: standardize code style in Neuwo RTD example - Convert single quotes to double quotes for consistency - Format code with Prettier * docs: add guide for accessing Neuwo RTD data outside Prebid.js * feat: add concurrent bid request handling to Neuwo RTD Module * chore: standardize log message format in Neuwo RTD Module * feat: add product identifier to Neuwo API requests * docs: fix typo in test file name in Neuwo RTD Module documentation * style: format Neuwo RTD Module with Prettier - Add `// prettier-ignore` comment to preserve quoted keys in `IAB_CONTENT_TAXONOMY_MAP` - Apply Prettier formatting to *modules/neuwoRtdProvider.js* * test: add coverage for concurrent requests and product identifier in Neuwo RTD Module * feat: add per-tier IAB taxonomy filtering to Neuwo RTD Module Add optional filtering configuration for IAB Content and Audience taxonomies, allowing publishers to control the quantity and quality of categories injected into bid requests. - Add `iabTaxonomyFilters` parameter to module configuration for per-tier filtering - Implement `filterIabTaxonomyTier()` function to filter taxonomies by relevance threshold and limit count - Implement `filterIabTaxonomies()` function to apply filters across all tiers using tier key mapping - Add integration example checkbox to enable/disable filtering with hardcoded filter values * docs: add IAB taxonomy filtering documentation to Neuwo RTD Module * test: add error handling and edge case tests for Neuwo RTD Module - Add test for API URL construction when `neuwoApiUrl` contains existing query parameters - Add tests for error response handling: 404 errors, pending request cleanup, and retry behaviour - Add tests for concurrent requests with errors ensuring all callbacks are invoked - Add tests for JSON parsing errors in success callback - Add test for retry after JSON parsing error - Add test for missing `marketing_categories` field in API response - Add test for sorting items with undefined/null relevance values - Reorganise test structure: nest caching, URL stripping, and filtering describes under main `getBidRequestData` block - Add documentation for generating test coverage reports with viewing instructions * style: apply formatting to Neuwo RTD Module markdown documentation * refactor: remove name field from IAB segments in ORTB2 output - Update `buildIabData()` to only include `id` in segment objects - Remove `label` requirement; segments now only need valid `ID` - Update documentation examples to reflect simplified segment structure - Update unit tests to match new segment format * feat: migrate Neuwo RTD Module to new API architecture (v2.0.0) and maintain backward compatibility - Add version 2.0.0 with multi-version IAB Content Taxonomy support - Implement automatic API capability detection from endpoint URL format - Maintain backward compatibility with legacy GET endpoints - Consolidate default IAB Content Taxonomy version to "2.2" constant - Transform legacy API responses to unified segtax-based format - Add `buildIabFilterConfig()` for filter configuration conversion - Add `transformV1ResponseToV2()` and `transformSegmentsV1ToV2()` helpers - Refactor `buildIabData()` to dynamically process all tiers - Update `injectIabCategories()` to work with unified response format - Enhance JSDoc documentation with format examples and API details - Add conditional logging for POST request bodies - Optimise filtering: apply once before caching for legacy endpoints * test: update Neuwo RTD Module tests for new API architecture - Update all test mocks to use new segtax-based response format - Add tests for `buildIabFilterConfig()` function - Add tests for `injectIabCategories()` function - Add tests for `transformV1ResponseToV2()` function - Add tests for `transformSegmentsV1ToV2()` function - Update `buildIabData()` tests to use new tierData parameter structure - Add V1 API backward compatibility test suite with client-side filtering tests - Verify POST method and iabVersions query parameters for new API - Verify GET method and no iabVersions parameter for legacy V1 API - Update edge case tests for empty responses and error handling - Update integration tests for URL parameter handling with query strings - Remove hardcoded tier array constants (CONTENT_TIERS, AUDIENCE_TIERS) * docs: update Neuwo RTD Module documentation for new API version - Change default IAB Content Taxonomy version from "3.0" to "2.2" - Add IAB Content Taxonomy version "1.0" to supported values list - Add server-side filtering explanation to IAB Taxonomy Filtering section - Update Available Tiers table to focus on taxonomy types instead of API internals - Add recommended configuration comments for `auctionDelay` and `waitForIt` - Update all configuration examples to use "2.2" as default taxonomy version - Remove "How it works" section * feat: add OpenRTB 2.5 category fields support to Neuwo RTD Module Add support for populating OpenRTB 2.5 category fields (`site.cat`, `site.sectioncat`, `site.pagecat`, `site.content.cat`) with IAB Content Taxonomy 1.0 segments. Changes: - Add `enableOrtb25Fields` configuration parameter (default: true) - Add `extractCategoryIds()` helper function to extract segment IDs from tier data - Refactor `buildIabData()` to use `extractCategoryIds()` for code reuse - Extend `buildIabFilterConfig()` to apply filters to IAB 1.0 when feature enabled - Modify `getBidRequestData()` to request IAB 1.0 data (segtax 1) when feature enabled - Add warning when feature enabled with legacy API endpoint - Extend `injectIabCategories()` to populate four OpenRTB 2.5 category fields - Update version to 2.1.0 * ci: add OpenRTB 2.5 category fields support to integration example Changes: - Add checkbox UI control for `enableOrtb25Fields` option (default: checked) - Add display section for OpenRTB 2.5 category fields data - Extract and display `site.cat`, `site.sectioncat`, `site.pagecat`, and `site.content.cat` fields - Update `bidRequested` event handler to capture category fields - Add localStorage persistence for `enableOrtb25Fields` setting - Pass `enableOrtb25Fields` parameter to module configuration * test: add unit tests for OpenRTB 2.5 category fields Changes: - Add 11 new `buildIabFilterConfig()` tests for OpenRTB 2.5 feature (enabled/disabled scenarios) - Add 11 new `extractCategoryIds()` tests covering all edge cases - Add 11 new `injectIabCategories()` tests for category field injection - Update 5 existing `buildIabFilterConfig()` tests - Add 6 new `getBidRequestData()` integration tests for V2 API with feature enabled/disabled - Move legacy API compatibility tests from V2 section to V1 section * docs: add OpenRTB 2.5 category fields support documentation to Neuwo RTD Module Changes: - Add OpenRTB 2.5 feature description to module overview - Add `enableOrtb25Fields` parameter to parameters table - Add dedicated "OpenRTB 2.5 Category Fields" section with examples - Update ORTB2 data structure examples to show category fields - Add filtering section explaining IAB 1.0 filter application - Update "Accessing Neuwo Data" section with category field extraction example - Add "Building for Production" section with build command - Update segtax value in example (7 → 6) - Update version to 2.1.0 * perf: change Content-Type to text/plain to avoid CORS preflight * refactor: change /v1/iab endpoint from POST to GET with flattened query params Replace POST request with GET and send IAB taxonomy filters as flattened URL query parameters instead of JSON body to avoid CORS preflight requests. Changes: - Replace `buildIabFilterConfig()` with `buildFilterQueryParams()` function - Change output from nested object to array of query parameter strings (e.g., `["filter_6_1_limit=3"]`) - Remove POST method and request body from ajax call - Add filter parameters directly to URL for /v1/iab endpoint - Maintain OpenRTB 2.5 filter application (ContentTier1/2 → segtax 1) - Update all unit tests to test `buildFilterQueryParams()` instead of `buildIabFilterConfig()` - Update tests expecting POST requests to expect GET requests - Update tests checking request body to check URL parameters - Update version to 2.2.0 * feat: key cache by full API URL to support config changes between auctions - Replace global `cachedResponses` and `pendingRequests` singletons with objects keyed by `neuwoApiUrlFull` - Concurrent or sequential calls with different parameters (URL, taxonomy version, filters) maintain separate cache entries - Add LRU-style eviction capped at 10 entries to prevent unbounded cache growth - Log module version during `init()` - Add unit tests for cache isolation * fix: guard empty URLs, inject content/audience independently, allow `limit: 0` to suppress tiers - Separate JSON parsing from response processing into distinct try/catch blocks - Add `Array.isArray` guard to `extractCategoryIds` - Only cache valid object responses so failed requests can be retried - Rename `isV2Api` to `isIabEndpoint` for clarity - Fix typo in log message and JSDoc (POST -> GET) - Bump to 2.2.1 * fix: isolate legacy endpoint cache keys by taxonomy version and filters * fix: prevent duplicate filter query params when IAB Content Taxonomy is 1.0 * fix: only sort and filter taxonomy tiers when filter is configured * fix: detect /v1/iab endpoint from URL pathname instead of full string * fix: prevent duplicate `iabVersions=1` query param when content taxonomy is 1.0 --------- Co-authored-by: grzgm <125459798+grzgm@users.noreply.github.com> Co-authored-by: gregneuwo <226034698+gregneuwo@users.noreply.github.com>
* aceexBidAdapter/setup * aceexBidAdapter/setup and fixes * aceexBidAdapter/setup merge * prices logic fix * prices logic fix * prices logic fix * prices logic fix * prices logic fix * prices logic fix * review smallfixes --------- Co-authored-by: vrishko <vasyl.rishko@smartyads.com>
* manage burl object * fix lint * burl to burls * stringify only when method post
…id#14373) * enhance ORTB 2.6 support and enhance bid response handling * remove onBidWon * add tests for handling 204 No Content responses in InsticatorBidAdapter * update InsticatorBidAdapter and improve TTL handling * udpate media type detection in InsticatorBidAdapter to support ORTB 2.6 standards * remove adpod fields references
* New adapter: concepx * Syntax change * Revert syntax change * Defensive check for response from bidder server * Add better validation for the request * Merge branch 'master' of https://github.com/prebid/Prebid.js * Don't append url on every buildrequest * Add gvlId to conceptX * Change conceptx adapter, to directly request our PBS * Add empty getUserSync, as the syncing will be delegated (runPbsCookieSync) --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* Make TypeScript fields optional * Fix condition name
* OMS Adapter: extract shared OMS/Onomagic helper utilities * OMS Adapter: extract shared banner size/viewability processing * OMS Adapter: isolate viewability helpers to avoid eager side effects
* bidResponseFilter: cattax handling * default meta value * Normalize cattax values for accurate comparison Normalize cattax values before comparison to ensure accurate matching. --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Anna Yablonsky <annay+perion@perion.com>
* adding new adapter for Admination * remove alias for adnimation form limelightDigital following new partnership --------- Co-authored-by: Anna Yablonsky <annay+perion@perion.com>
…prebid#14515) * TeqBlazeSalesAgent Bid Adapter: initial release * update doc * fix for uspConsent string in getUserSyncs * fix test --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* ADJS-1646-update-userId-handling * added test: should filter pubProvidedId entries by allowed sources * support ortb2.user.ext.eids fallback and add identity parity tests * Prioritize prebid.js 10 structure * GumGum Adapter: fix TDID extraction across all EID uids and add edge-case tests
* mediafuseBidAdapter Updates and Refactor * Addressed Flagged Issues and removed ADPOD import. * More Fixes * bug fixes, code quality improvements, and expanded test coverage * Updates and Fixes * Flagged Issues Fixes
…rebid#14529) This reverts commit 192f96a.
* Add user sync and reporting urls * add tests, minor refactor * add window.addEventListener only once * fix JSON.parse can return null * Fix unconditional setting user.ext.uids * Add test * swap uids from storage and original user.ext.uids * Add keepalive and log only when debug is turned on --------- Co-authored-by: Michal Kváček <michal.kvacek@performax.cz>
…4429)" (prebid#14532) This reverts commit d8fb435.
Bumps [browserstack-local](https://github.com/browserstack/browserstack-local-nodejs) from 1.5.5 to 1.5.11. - [Release notes](https://github.com/browserstack/browserstack-local-nodejs/releases) - [Commits](browserstack/browserstack-local-nodejs@v1.5.5...v1.5.11) --- updated-dependencies: - dependency-name: browserstack-local dependency-version: 1.5.11 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.3.6 to 5.4.1. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.3.6...v5.4.1) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add pubstackBidAdapter (#1) * feat: add SparkBidAdapter * fix: reviews * fix: use iframe for user_sync * fix: change adapter name * fix: add test file * feat: add viewport value in imp[].ext.prebid.bidder.pubstack.vpl * fix: remove unused context * Pubstack Adapter: update utils and align adapter tests * Pubstack Bid Adapter: apply lint-driven TypeScript cleanups --------- Co-authored-by: gpolaert <gpolaert@pubstack.io> * Update modules/pubstackBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/pubstackBidAdapter.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update libraries/pubstackUtils/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/pubstackBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Pubstack Adapter: use placementPositionInfo telemetry --------- Co-authored-by: Stéphane Deluce <boluge@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v7...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ult behavior in prebid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Supporting native media type in addition to the existing banner support in Taboola adapter.
Other information