Conversation
…al labels on the boards, other tweaks.
Chore/ror qol improvements
Fig generator
Feature/profile
limit profiling temp accuracy to .1 degree disable specific sliders when automation is active data "ergonomics"
Feature/firmware hardening
There was a problem hiding this comment.
Copilot reviewed 39 out of 49 changed files in this pull request and generated 2 comments.
Files not reviewed (10)
- PCB/YaegerV01BOM_FULL.csv: Language not supported
- build_and_flash.sh: Language not supported
- miniweb/src/style.css: Language not supported
- platformio.ini: Language not supported
- src/CommandLoop.cpp: Language not supported
- src/api.cpp: Language not supported
- src/api.h: Language not supported
- src/config.h: Language not supported
- src/fan.cpp: Language not supported
- src/main.cpp: Language not supported
Comments suppressed due to low confidence (3)
python fig gen/guide.md:1
- [nitpick] Consider rephrasing for clarity; for example, 'A guide on using the generator' may be clearer.
# A guide how to for the gen
miniweb/src/main.ts:265
- Consider escaping the dot before milliseconds in the regex (i.e., use .) to ensure accurate ISO date matching.
if (typeof value === "string" && /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z$/.test(value)) {
README.md:44
- Replace 'preffered' with 'preferred' for correct spelling.
After setting up the preffered Wifi, Yaeger will try to connect to it on every boot.
Comment on lines
+15
to
+16
| You now have the choice to either active the .venv | ||
|
|
There was a problem hiding this comment.
Please correct 'active' to 'activate' for proper verb usage.
Suggested change
| You now have the choice to either active the .venv | |
| You now have the choice to either activate the .venv |
Comment on lines
+19
to
20
| ### Suported hardware | ||
|
|
There was a problem hiding this comment.
Correct 'Suported' to 'Supported' to fix the typo.
Suggested change
| ### Suported hardware | |
| ### Supported hardware |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.