Skip to content

Conversation

@Mingun
Copy link
Collaborator

@Mingun Mingun commented Oct 25, 2025

Serde 1.0.221 deprecated serde_if_integer128 macro, which leads to warnings when compile quick-xml. That macro does nothing since serde 1.0.187, and since 1.0.180 serde requires compiler >=1.26 which stabilizes 128-bit integers.

So it seems that it is enough to require serde >=1.0.180

@Mingun Mingun added the serde Issues related to mapping from Rust types to XML label Oct 25, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.74%. Comparing base (38b44d4) to head (cb34329).
⚠️ Report is 36 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   55.52%   57.74%   +2.22%     
==========================================
  Files          42       42              
  Lines       15511    15422      -89     
==========================================
+ Hits         8613     8906     +293     
+ Misses       6898     6516     -382     
Flag Coverage Δ
unittests 57.74% <ø> (+2.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun
Copy link
Collaborator Author

Mingun commented Oct 25, 2025

I do not like to bump dependencies in patch releases so hold this until minor release. I did not look at #904 yet, so if it go into patch, I'll merge it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

serde Issues related to mapping from Rust types to XML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants