Some cleanup in tests #910
Merged
+78
−246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some was removed in tafia#821, but not all
Remove the same ignored test from serde-migrated That was fixed in tafia#865
Input tested by
-----------------------------------------------------------------
serde-se
<bla>This is a String</bla> with_root::str_non_escaped
<bla></bla> with_root::str_empty
<bla> </bla> with_root::str_spaces_only
<bla><boom/></bla> with_root::str_escaped
The following inputs tested only for deserialization and have a rough
equivalent in existing tests:
reader-references
<bla>♫</bla> character_reference::dec::text
<bla>♫</bla> character_reference::hex::text
--lib
<bla>♫<![CDATA[<cookies/>]]>♫</bla> de::tests::triples::text::cdata::text
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 55.52% 58.17% +2.65%
==========================================
Files 42 42
Lines 15511 15547 +36
==========================================
+ Hits 8613 9045 +432
+ Misses 6898 6502 -396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e-de` `test_namespaces` equivalent to `struct_::namespaces`. `test_forwarded_namespace` has no equivalent, but it was ignored anyway. New tests will be written during solving tafia#218
dralley
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old tests, borrowed from (as it seems) xml-rs, that have equivalents in our testset.