Skip to content

Add an import#1

Open
mzinger wants to merge 3 commits intotagel:masterfrom
mzinger:patch-1
Open

Add an import#1
mzinger wants to merge 3 commits intotagel:masterfrom
mzinger:patch-1

Conversation

@mzinger
Copy link
Copy Markdown

@mzinger mzinger commented Jul 27, 2019

Math shmath!


This change is Reviewable

Math shmath!
Copy link
Copy Markdown
Owner

@tagel tagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

@@ -1,2 +1,3 @@
import math
import shmath
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no such thing as shmath

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is.

Copy link
Copy Markdown
Author

@mzinger mzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@@ -1,2 +1,3 @@
import math
import shmath
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is.

Co-Authored-By: tagel <tagelshaked@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants