Skip to content

Use ESLint installed as project dependency before looking for global installation of ESLint #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ydsood wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −7
Open

Use ESLint installed as project dependency before looking for global installation of ESLint #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions eslint_linter/src/ArcanistEslintLinter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ public function getLinterConfigurationOptions() {
final public function lintPath($path) {}

public function willLintPaths(array $paths) {
$this->checkEslintInstallation();
$this->execution = new ExecFuture('eslint --format=json --no-color ' . implode($paths, ' '));
if(!$this->checkLocalEslintInstallation() && !$this->checkGlobalEslintInstallation()){
throw new ArcanistUsageException(
pht('Eslint is not installed, please run `npm install eslint` or add it to your package.json')
);
}

$this->setExecution($paths);
$this->didRunLinters();
}

Expand All @@ -47,14 +52,29 @@ final public function didRunLinters() {
}
}

private function checkEslintInstallation() {
if (!Filesystem::binaryExists('eslint')) {
throw new ArcanistUsageException(
pht('Eslint is not installed, please run `npm install eslint` or add it to your package.json')
);
private function checkGlobalEslintInstallation() {
if (Filesystem::binaryExists('eslint')) {
return true;
}
return false;
}

private function checkLocalEslintInstallation(){
if (Filesystem::binaryExists('.\node_modules\.bin\eslint')) {
return true;
}
return false;
}

private function setExecution(array $paths){
if($this->checkLocalEslintInstallation()){
$this->execution = new ExecFuture('.\node_modules\.bin\eslint --format=json --no-color ' . implode($paths, ' '));
}
else{
$this->execution = new ExecFuture('eslint --format=json --no-color ' . implode($paths, ' '));
}
}

protected function parseLinterOutput($output) {
$json = json_decode($output, true);

Expand Down