Skip to content

Conversation

@Arshadul-Monir
Copy link
Collaborator

@Arshadul-Monir Arshadul-Monir commented Jan 29, 2026

698

…completed embed messages

Description of changes

Updated the Discord embed message to include the following line:

View the full leaderboard for {clubName} users at https://codebloom.patinanetwork.org/leaderboard?{tag}=true

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

New Leaderboard message:
image

Weekly message:
image

Staging

@github-actions
Copy link
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@github-actions
Copy link
Contributor

Title

698: Added "view full leaderboard" message to both weekly update and …


PR Type

Enhancement


Description

  • Add full leaderboard link to embeds

  • Include club name and tag parameters

  • Update completed and weekly messages

  • Preserve existing leaderboard content


Diagram Walkthrough

flowchart LR
  A["DiscordClubManager embeds"] -- "append link line" --> B["Completed message"]
  A -- "append link line" --> C["Weekly update message"]
  B -- "format with clubName & tag" --> D["Leaderboard URL with query"]
  C -- "format with clubName & tag" --> D
Loading

File Walkthrough

Relevant files
Enhancement
DiscordClubManager.java
Add club-specific leaderboard link to embeds                         

src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java

  • Append leaderboard link line to completed embed
  • Append leaderboard link line to weekly update embed
  • Interpolate club.getName() and lowercase club.getTag() into URL
  • Keep existing formatting and variables intact
+8/-0     

@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

URL Hardcoding

The leaderboard URL is hardcoded in the embed text. Consider using an existing base URL utility (e.g., server URL utils or config) to avoid environment mismatches and ease future changes.

View the full leaderboard for %s users at https://codebloom.patinanetwork.org/leaderboard?%s=true
Null/Formatting Safety

The format string adds two new placeholders that rely on club name and tag. Ensure club.getName() and club.getTag() are always present and safe to render (no nulls, unexpected characters) to prevent runtime formatting issues or malformed URLs.

club.getName(),
club.getTag().name().toLowerCase(),
serverUrlUtils.getUrl());

@Arshadul-Monir
Copy link
Collaborator Author

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit d700b0d has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment failed for commit d700b0d

View run

@Arshadul-Monir
Copy link
Collaborator Author

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit 905267f has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit 905267f

View run

@Arshadul-Monir Arshadul-Monir force-pushed the 698 branch 2 times, most recently from d700b0d to c62b757 Compare January 30, 2026 16:45
@Arshadul-Monir
Copy link
Collaborator Author

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit c62b757 has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit c62b757

View run

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Arshadul-Monir
Copy link
Collaborator Author

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit 7fa8108 has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit 7fa8108

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants