Add support for Python 2.7 and 3.4 using six#6
Open
morenosan wants to merge 3 commits intotaichino:masterfrom
Open
Add support for Python 2.7 and 3.4 using six#6morenosan wants to merge 3 commits intotaichino:masterfrom
morenosan wants to merge 3 commits intotaichino:masterfrom
Conversation
Improve Python 2 & 3 compatiblity, declare it in setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've ported the package to support Python 3.4 using six. Installation works in 2.7 and 3.4 and tests passes in both versions.
The changes are minimal on the code but I had to change the setup.py file to install six as a dependency. Also I had to remove the execution of the tests previous to the installation because when setup.py is executed, six still is not installed. Tests can be executed with:
Finally I added a README file, that is also used as the long_description field.
Hope you find it useful.