Skip to content

mkctr: add support for volumes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raggi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mkctr: add support for volumes #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion mkctr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ type buildParams struct {
target string
verbose bool
annotations map[string]string // OCI image annotations
volumes map[string]struct{}
}

func main() {
Expand All @@ -92,6 +93,7 @@ func main() {
gopaths = flag.String("gopaths", "", "comma-separated list of go paths in src:dst form")
files = flag.String("files", "", "comma-separated list of static files in src:dst form")
repos = flag.String("repos", "", "comma-separated list of image registries")
volumes = flag.String("volumes", "", "comma-separated list of volumes to add")
tagArg = flag.String("tags", "", "comma-separated tags")
ldflagsArg = flag.String("ldflags", "", "the --ldflags value to pass to go")
gotags = flag.String("gotags", "", "the --tags value to pass to go")
Expand Down Expand Up @@ -133,6 +135,13 @@ func main() {
if len(paths) == 0 && len(staticFiles) == 0 {
log.Fatal("at least one of --files or --gopaths must be set")
}
var vols map[string]struct{}
for vol := range strings.SplitSeq(*volumes, ",") {
if vols == nil {
vols = make(map[string]struct{})
}
vols[strings.TrimSpace(vol)] = struct{}{}
}

bp := &buildParams{
baseImage: *baseImage,
Expand All @@ -145,6 +154,7 @@ func main() {
target: *target,
verbose: *verbose,
annotations: parseAnnotations(*annotations),
volumes: vols,
}

if err := fetchAndBuild(bp); err != nil {
Expand Down Expand Up @@ -304,7 +314,8 @@ func fetchAndBuild(bp *buildParams) error {

if args := flag.Args(); len(args) > 0 {
img, err = mutate.Config(img, v1.Config{
Cmd: args,
Cmd: args,
Volumes: bp.volumes,
})
if err != nil {
return err
Expand Down