Skip to content

Use runtime.GOARCH to determine architecture of container build for darwin #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChaosInTheCRD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use runtime.GOARCH to determine architecture of container build for darwin #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions mkctr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,9 @@ func canRunLocal(p v1.Platform) bool {
if p.OS != "linux" {
return false
}
if runtime.GOOS == "linux" {
if runtime.GOOS == "linux" || runtime.GOOS == "darwin" {
return p.Architecture == runtime.GOARCH
}
if runtime.GOOS == "darwin" {
// macOS can run amd64 linux binaries in docker.
return p.Architecture == "amd64"
}
return false
}

Expand Down