-
Notifications
You must be signed in to change notification settings - Fork 544
android: add selection of included/excluded apps in split tunneling #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
android: add selection of included/excluded apps in split tunneling #621
Conversation
Updates tailscale/tailscale#14660 Signed-off-by: davfsa <davfsa@gmail.com>
91cf3af
to
fbcd071
Compare
Signed-off-by: davfsa <davfsa@gmail.com>
Pull Request Revisions
✅ AI review completed for r5 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
android/src/main/java/com/tailscale/ipn/ui/view/SplitTunnelAppPickerView.kt
Show resolved
Hide resolved
android/src/main/java/com/tailscale/ipn/ui/view/SplitTunnelAppPickerView.kt
Show resolved
Hide resolved
944d0f8
to
6b210ba
Compare
Signed-off-by: davfsa <davfsa@gmail.com>
Hey @barnstar, sorry for the ping, but its been a little while, would it be possible to get a review? Thanks! And again, sorry for the ping! |
Signed-off-by: davfsa <davfsa@gmail.com>
Ability to merge seems stuck, so closing and re-opening to try and get it fixed :) |
android/src/main/java/com/tailscale/ipn/ui/view/SplitTunnelAppPickerView.kt
Show resolved
Hide resolved
android/src/main/java/com/tailscale/ipn/ui/view/SplitTunnelAppPickerView.kt
Show resolved
Hide resolved
android/src/main/java/com/tailscale/ipn/ui/viewModel/SplitTunnelAppPickerViewModel.kt
Show resolved
Hide resolved
android/src/main/java/com/tailscale/ipn/ui/view/SplitTunnelAppPickerView.kt
Show resolved
Hide resolved
This is the feature I've been waiting for! It would make the app perfect! |
This function is signficantly useful for all of Tailscale Android users. No attention here? It is sad. |
Seconding this 1000x. |
Hello!
I took a stab at adding the ability to select included/excluded apps from App Split Tunneling instead of only allowing selecting excluded applications.
All images are 1280x2856, so you can open them in a new tab to view them better
A couple of points:
DISALLOWED_APPS_KEY
(nowSELECTED_APPS_KEY
) is in a bit of a weird situation as the value no longer represents the variable name. I havent opted to add a migration flow for the key, but can be done if needed. For now I have just added a comment above explaining the the reasonswitchUserSelectedPackages
is not the best of names, but I couldn't come up with any better, will update with any suggestions or if I come up with a better oneCloses tailscale/tailscale#14660