Fix error handler for maps and implemented converter of list fromatted configuration to record#120
Open
cleverfox wants to merge 2 commits intotalentdeficit:developfrom
Open
Fix error handler for maps and implemented converter of list fromatted configuration to record#120cleverfox wants to merge 2 commits intotalentdeficit:developfrom
cleverfox wants to merge 2 commits intotalentdeficit:developfrom
Conversation
cleverfox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I made a little patch for being able to resume encoding term to JSON in case of key is a bad string. Current implementation of error handler and jsx_parser:resume didn't work with maps. Also something was wrong with config, which was converted to list before calling error handler, but jsx_parser:resume expects record. I done this to use error handler for encoding binary (non printable) keys and/or values in maps and/or arrays. Examples in tests.