Allow tuples in input terms with the [tuples_to_lists] option#148
Open
brigadier wants to merge 8 commits intotalentdeficit:mainfrom
Open
Allow tuples in input terms with the [tuples_to_lists] option#148brigadier wants to merge 8 commits intotalentdeficit:mainfrom
brigadier wants to merge 8 commits intotalentdeficit:mainfrom
Conversation
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
Author
|
I'd add that this pull is not ready for getting accepted yet until I add support for datetimes and some tests. It's here for discussing about whether should it be accepted or not. |
Contributor
|
You can convert this to a draft if you think it better signals your intention. |
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
… C} and {{A, B, C}, {D, E, F}} to datetime. Converts to lists instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow encoding terms containing tuples with the
[tuples_to_lists]option of theencodefunction. Tuples are encoded as lists. No exception is made for the[{}]and[{k, v}, ...]special cases, and in the current implementation DateTime objects are also encoded as lists.The rationale for this pull is that in newer erlang projects structures represeting key -> value pairs generally move from proplists to maps,
encodeanddecodefunctions are not invertible anyway, and transforming manually each and every tuple to list manually before encoding is a tedious job.Without this option it is fully compatible with previous versions.
I can also add conversion of one-tuple and two-tuple to timestamps, but not sure if this should be default behaviour or a configurable with another paremeter(s) one.