Skip to content

update install guide - pyproject.toml didn't have [core]#61

Open
finnjclancy wants to merge 1 commit intotalos-agent:mainfrom
finnjclancy:fix-readme-install-instructions
Open

update install guide - pyproject.toml didn't have [core]#61
finnjclancy wants to merge 1 commit intotalos-agent:mainfrom
finnjclancy:fix-readme-install-instructions

Conversation

@finnjclancy
Copy link

the old install command was:

uv pip install -e .[core, dev]

pyproject.toml does not define core, just defines dev

line updated to be:

uv pip install -e ".[core, dev]"

@talos-agent
Copy link
Owner

🤖 Talos PR Review

  1. Summary of PR:
    The pull request is a minor change to the installation guide in the README.md file. The change is in the command for installing dependencies. The previous command was uv pip install -e .[core,dev] and it has been changed to uv pip install -e ".[dev]". This suggests that the 'core' dependencies are no longer required or have been merged into 'dev'.

  2. Security Assessment:
    Score: 100
    There are no security concerns with this PR. It's a simple change in the documentation and doesn't affect the codebase or introduce any potential vulnerabilities.

  3. Code Quality Assessment:
    Score: 100
    The PR doesn't involve any code changes, only documentation. The change is clear and concise, and it doesn't introduce any ambiguity or complexity.

  4. Recommendations for Improvement:
    There are no major issues with this PR. However, it would be helpful if the author could provide a brief explanation for the change in the PR description. For example, why was the 'core' dependency removed? This would help other developers understand the reason behind the change.

  5. Overall Recommendation: COMMENT
    The PR is generally fine, but it would be beneficial to have a bit more context or explanation for the change. Therefore, I would recommend to COMMENT and ask the author to provide this information.

Recommendation: COMMENT


This review was generated automatically by Talos AI

@johnny-emp johnny-emp force-pushed the main branch 3 times, most recently from ccf2936 to 015ec79 Compare September 10, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants