fix(commit-msg): reject commit subjects with trailing period#15
Merged
tannn merged 2 commits intocommit-normalizefrom Mar 3, 2026
Merged
fix(commit-msg): reject commit subjects with trailing period#15tannn merged 2 commits intocommit-normalizefrom
tannn merged 2 commits intocommit-normalizefrom
Conversation
4 tasks
Co-authored-by: tannn <831788+tannn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix commit message normalization via conventional-commits hook
fix(commit-msg): reject commit subjects with trailing period
Mar 3, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tannn
added a commit
that referenced
this pull request
Mar 3, 2026
* chore: add conventional-commits commit-msg hook and setup script Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift * fix(commit-msg): reject commit subjects with trailing period (#15) * Initial plan * fix: reject commit subjects ending with a trailing period Co-authored-by: tannn <831788+tannn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tannn <831788+tannn@users.noreply.github.com> * fix(setup-hooks): resolve destination from core.hooksPath (#16) * Initial plan * fix: resolve hook destination from git config core.hooksPath Co-authored-by: tannn <831788+tannn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tannn <831788+tannn@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tannn <831788+tannn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
commit-msghook documented a "no trailing period" rule but the regex had no end-of-line anchor, sofix: add parser.passed silently.Change
Updated
PATTERNingit-hooks/commit-msg:$anchors the match so the regex can't satisfy itself on a prefix of the subject[^.]as the final required character blocks a trailing period?group keeps single-character descriptions (e.g.fix: a) valid✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.