Skip to content

fix(commit-msg): reject commit subjects with trailing period#15

Merged
tannn merged 2 commits intocommit-normalizefrom
copilot/sub-pr-14
Mar 3, 2026
Merged

fix(commit-msg): reject commit subjects with trailing period#15
tannn merged 2 commits intocommit-normalizefrom
copilot/sub-pr-14

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

The commit-msg hook documented a "no trailing period" rule but the regex had no end-of-line anchor, so fix: add parser. passed silently.

Change

Updated PATTERN in git-hooks/commit-msg:

# Before — no end anchor, trailing period accepted
PATTERN="^(${TYPES})(\([a-z0-9]([a-z0-9-]*[a-z0-9])?\))?!?: [a-z].{1,}"

# After — anchored, trailing period rejected, single-char descriptions allowed
PATTERN="^(${TYPES})(\([a-z0-9]([a-z0-9-]*[a-z0-9])?\))?!?: [a-z]([^.]|.*[^.])?$"
  • $ anchors the match so the regex can't satisfy itself on a prefix of the subject
  • [^.] as the final required character blocks a trailing period
  • Optional ? group keeps single-character descriptions (e.g. fix: a) valid

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: tannn <831788+tannn@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix commit message normalization via conventional-commits hook fix(commit-msg): reject commit subjects with trailing period Mar 3, 2026
Copilot finished work on behalf of tannn March 3, 2026 06:54
@tannn tannn marked this pull request as ready for review March 3, 2026 07:45
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tannn tannn merged commit 87ddd8d into commit-normalize Mar 3, 2026
@tannn tannn deleted the copilot/sub-pr-14 branch March 3, 2026 07:45
tannn added a commit that referenced this pull request Mar 3, 2026
* chore: add conventional-commits commit-msg hook and setup script

Nightshift-Task: commit-normalize
Nightshift-Ref: https://github.com/marcus/nightshift

* fix(commit-msg): reject commit subjects with trailing period (#15)

* Initial plan

* fix: reject commit subjects ending with a trailing period

Co-authored-by: tannn <831788+tannn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tannn <831788+tannn@users.noreply.github.com>

* fix(setup-hooks): resolve destination from core.hooksPath (#16)

* Initial plan

* fix: resolve hook destination from git config core.hooksPath

Co-authored-by: tannn <831788+tannn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tannn <831788+tannn@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tannn <831788+tannn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants