fix: add rate limiting and field size limits to feedback endpoint#112
Open
JasonOA888 wants to merge 1 commit intotanweai:mainfrom
Open
fix: add rate limiting and field size limits to feedback endpoint#112JasonOA888 wants to merge 1 commit intotanweai:mainfrom
JasonOA888 wants to merge 1 commit intotanweai:mainfrom
Conversation
Issue tanweai#96: Security hardening for POST /api/feedback Changes: - Add IP-based rate limiting (5 requests/hour per IP) - Add field size limits to prevent storage exhaustion: - session_data: 10KB max - task_summary: 1KB max - rating: 50 chars max - flavor: 100 chars max - Add KV namespace binding for rate limiter (optional) - Return 429 status when rate limited The rate limiting uses Cloudflare KV with TTL-based expiration. Without KV binding, the endpoint still works but without rate limiting. Fixes tanweai#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
Summary
Security hardening for the POST /api/feedback endpoint.
Changes
Backward Compatibility