Skip to content

fix: correct broken relative protocol file paths in P7/P9/P10 agents#154

Open
xiaolai wants to merge 1 commit intotanweai:mainfrom
xiaolai:fix/nlpm-agent-broken-protocol-paths
Open

fix: correct broken relative protocol file paths in P7/P9/P10 agents#154
xiaolai wants to merge 1 commit intotanweai:mainfrom
xiaolai:fix/nlpm-agent-broken-protocol-paths

Conversation

@xiaolai
Copy link
Copy Markdown

@xiaolai xiaolai commented Apr 26, 2026

Automated audit: This PR was generated by NLPM, a natural language programming linter, running via claude-code-action. Please evaluate the diff on its merits.

Bug

Three agent files reference their protocol files using a relative path that resolves to the wrong directory:

cat 同目录下的 references/p9-protocol.md   # in agents/tech-lead-p9.md
cat 同目录下的 references/p10-protocol.md  # in agents/cto-p10.md
cat 同目录下的 references/p7-protocol.md   # in agents/senior-engineer-p7.md

The phrase "同目录下的" ("in the same directory") makes Claude look for these files relative to agents/ — i.e., at agents/references/. That directory does not exist. The actual protocol files live at:

skills/pua/references/p7-protocol.md
skills/pua/references/p9-protocol.md
skills/pua/references/p10-protocol.md

When Claude follows the broken instruction it silently fails to load the protocol, so the agent starts without its core methodology (四阶段工作流, Task Prompt 六要素, 失败模式 etc.).

Fix

Replace every broken reference with the Glob-based pattern that senior-engineer-p7.md already uses correctly for SKILL.md loading:

找到 pua 插件目录下的 skills/pua/references/p9-protocol.md(用 Glob 搜索 **/pua/skills/pua/references/p9-protocol.md)

This is a pure path correction — no logic or behaviour changes.

Files changed: agents/tech-lead-p9.md, agents/cto-p10.md, agents/senior-engineer-p7.md

All three agents (tech-lead-p9, cto-p10, senior-engineer-p7) referenced
protocol files via "cat 同目录下的 references/p{7,9,10}-protocol.md",
which resolves to agents/references/ — a directory that does not exist.
The actual files are at skills/pua/references/. Replace with Glob pattern
consistent with the SKILL.md loading pattern already used by the agents.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant