we should not mention a specific version of engines #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of these, it is failing in latest version ps1: it may not needed to use those engine requirements at all ps2: even if we need them, better to have lower versions possible with which package works.
|
Agreed. I'm unable to use the latest version on node |
|
@stephen-puiszis I also made a pull request and hosted it @ https://www.npmjs.com/package/jcrop-robinflyhigh |
|
You can now install using yarn add jcrop-robinflyhigh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of these, it is failing in latest version
ps1: it may not needed to use those engine requirements at all
ps2: even if we need them, better to have lower versions possible with which package works.