Support downchirp frames dev #139
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @tapparelj,
first of all, thank you for this great project!
As others have had this issue (#123) before me, I require to receive downlink as well as uplink messages. I do not want to compromise receiving uplink frames, so adding a conjugate block before the
Frame Syncblock is not sufficient for me.Instead I modified your code inside the
Frame Syncblock - basically copying the input signal and repeat all necessary computations for the conjugated input signal. Incrementing two separate symbol_counters and lastly using the "normal" or conjugate input for the further computations, depending on which symbol_counter is larger.I tested my code with a dragino temperature and humidity sensor, which initially sends 2 packets with SF7 and 1 packet with SF12.
I successfully received the complete communication between the dragino sensor and my LoRaWAN gateway. So when sniffing for LoRaWAN packets with SF7, I get:
Wireshark is able to successfully dissect the packets, which proves to me that it works, but apparently my code extension is not stable. I recorded the communication between the GW and Sensor, so the input stays constant, however not all packets are constantly recognised by my flow graph. I used the
File Sourceblock and setrepeat=True. As you can see above, the second time only 3 out of 4 packets were received.To summarise, the code works, but still has some bugs/ is unstable.
With my limited knowledge in DSP, I am not able to figure out the last missing part, but I thought I leave this here. Maybe this partly solution helps somebody else as well, you or anybody else is motivated to look over it and spot the bug. I happily contribute, but am definitely not offended if you just decline this pull request.
Thanks again for all your work! Cheers!