feat(arrow, datetime, decimal, uuid): add support for go-option #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
force-pushed
the
bigbes/tntp-3735-generate-optional-extensions
branch
from
e3ed24c to
913ab89
Compare
|
Converted to draft until go-option v1.0.0 is released. |
bigbes
force-pushed
the
bigbes/tntp-3735-generate-optional-extensions
branch
from
913ab89 to
9e1d51b
Compare
bigbes
force-pushed
the
bigbes/tntp-3735-generate-optional-extensions
branch
from
9e1d51b to
c45b36a
Compare
oleg-jukovec
requested changes
Sep 9, 2025
arrow/arrow.go
Outdated
Comment on lines
31
to
40
| func (a Arrow) MarshalMsgpack() ([]byte, error) { | ||
| return a.data, nil | ||
| } | ||
|
|
||
| func (a *Arrow) UnmarshalMsgpack(data []byte) error { | ||
| a.data = data | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Please, add comments to the public API methods.
datetime/datetime.go
Outdated
Comment on lines
186
to
188
|
|
||
| func (d Datetime) MarshalMsgpack() ([]byte, error) { |
datetime/datetime.go
Outdated
Comment on lines
218
to
221
|
|
||
| func (d *Datetime) UnmarshalMsgpack(data []byte) error { |
bigbes
force-pushed
the
bigbes/tntp-3735-generate-optional-extensions
branch
from
64ac6f6 to
ae84793
Compare
|
macOS tests won't work for now (will be fixed by #462) |
Add support for `go-option` to the `arrow`, `datetime`, `decimal`, and `uuid` packages. This allows for handling optional values of the `Arrow`, `Datetime`, `Interval`, `Decimal`, `UUID` and `BoxError` types. The following changes have been made: - Added `go:generate` directives to the `Arrow`, `Datetime`, `Interval`, `Decimal`, `UUID` and `BoxError` types to generate optional types using `github.com/tarantool/go-option/cmd/gentypes`. - Implemented `MarshalMsgpack` and `UnmarshalMsgpack` methods for the `Arrow`, `Datetime`, `Interval`, and `Decimal` types. - Added `marshalUUID` and `unmarshalUUID` functions for the `UUID` type. - The generated `_gen.go` files contain the `Optional*` types that wrap the original types and provide methods to handle optional values, including `EncodeMsgpack` and `DecodeMsgpack` for `msgpack` serialization. - Refactored the `datetime` and `decimal` decoders to use the new `UnmarshalMsgpack` methods.
bigbes
force-pushed
the
bigbes/tntp-3735-generate-optional-extensions
branch
from
ae84793 to
2cb114b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
go-optionto thearrow,datetime,decimal, anduuidpackages. This allows for handling optional values of theArrow,Datetime,Interval,Decimal, andUUIDtypes.The following changes have been made:
go:generatedirectives to theArrow,Datetime,Interval,Decimal, andUUIDtypes to generate optional types usinggithub.com/tarantool/go-option/cmd/gentypes.MarshalMsgpackandUnmarshalMsgpackmethods for theArrow,Datetime,Interval, andDecimaltypes.marshalUUIDandunmarshalUUIDfunctions for theUUIDtype._gen.gofiles contain theOptional*types that wrap the original types and provide methods to handle optional values, includingEncodeMsgpackandDecodeMsgpackformsgpackserialization.datetimeanddecimaldecoders to use the newUnmarshalMsgpackmethods.Closes #TNTP-3735.