Skip to content

fix: capture:wrap boolean and table with errorable __index #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-enk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: capture:wrap boolean and table with errorable __index #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luatest/capture.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ function Capture.mt:wrap(enabled, fn)
return fn()
end, function(err)
-- Don't re-wrap error.
if err.type ~= self.class.CAPTURED_ERROR_TYPE then
if type(err) ~= 'table' or rawget(err, 'type') ~= self.class.CAPTURED_ERROR_TYPE then
err = {
type = self.class.CAPTURED_ERROR_TYPE,
original = err,
Expand Down
30 changes: 30 additions & 0 deletions test/capture_test.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,36 @@ g.test_wrap_with_error = function()
t.assert_equals(capture:flush(), {stdout = '', stderr = ''})
end

g.test_wrap_with_boolean_error = function()
local test_capture = Capture:new()
assert(not test_capture.enabled)
local ok, err = pcall(function() test_capture:wrap(true, function()
assert(test_capture.enabled)
error(true)
end) end)
t.assert_equals(ok, false)
assert(not test_capture.enabled)
t.assert_is(err.original, true)
t.assert_str_contains(err.traceback, "true")
t.assert_equals(test_capture:flush(), {stdout = '', stderr = ''})
t.assert_equals(capture:flush(), {stdout = '', stderr = ''})
end

g.test_wrap_with_errorable__index_error = function()
local test_capture = Capture:new()
assert(not test_capture.enabled)
local ok, err = pcall(function() test_capture:wrap(true, function()
assert(test_capture.enabled)
error(setmetatable({"error"}, {__index = error}))
end) end)
t.assert_equals(ok, false)
assert(not test_capture.enabled)
t.assert_is(err.original[1], "error")
t.assert_str_contains(err.traceback, "error")
t.assert_equals(test_capture:flush(), {stdout = '', stderr = ''})
t.assert_equals(capture:flush(), {stdout = '', stderr = ''})
end

g.test_wrap_disabled_with_error = function()
local test_capture = Capture:new()
assert(not test_capture.enabled)
Expand Down