Skip to content

[GOOD FIRST ISSUE] : Excessive vertical spacing between homepage sections #126 #129

Open
gaurika947 wants to merge 2 commits intotarinagarwal:mainfrom
gaurika947:main
Open

[GOOD FIRST ISSUE] : Excessive vertical spacing between homepage sections #126 #129
gaurika947 wants to merge 2 commits intotarinagarwal:mainfrom
gaurika947:main

Conversation

@gaurika947
Copy link

📝 Description
This PR addresses the excessive vertical spacing issues identified in #126. I have optimized the padding across the landing page sections to create a more compact and professional visual flow.

Key Changes:

Adjusted py-12 sm:py-20 classes to py-6 sm:py-10 in LandingPage.tsx.

Specifically targeted the gaps between the Feature Cards and the "Why Choose Edulume?" section to ensure more content is visible above the fold on medium and large screens.

Maintained responsive design integrity so the UI remains clean on mobile devices.

🔗 Related Issue
Closes #126

🏷️ Type of Change
[x] 🎨 Style/UI update

📸 Screenshots
BEFORE:-
Screenshot 2026-01-25 191313
AFTER :-
Screenshot 2026-01-25 203914

✅ Checklist
[x] My code follows the project's style guidelines

[x] I have performed a self-review of my code

[x] My changes generate no new warnings

[x] I have tested my changes locally

🧪 Testing
[x] Verified local build via npm run dev

📋 Additional Notes
This is my first contribution for SWOC 2026. I ensured that only the relevant layout files were modified to keep the PR focused on the specific spacing requirements of issue #126.

SWOC 2026 Participant

Copy link

@tarin-lgtm tarin-lgtm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested 🐈

This PR reduces excessive vertical spacing on the homepage by adjusting padding classes, improving visual flow and content visibility above the fold. The code changes are minor UI adjustments with no logic or security issues. However, the CertificateVerificationPage component lacks JSDoc documentation, which should be addressed.

There are a few things I'd like to see addressed before we merge this:

Before merging

  1. Add JSDoc documentation to the exported CertificateVerificationPage React component.
  2. Include inline comments in JSX sections to describe layout sections for better maintainability.
  3. Verify design consistency after padding adjustments to ensure visual coherence across devices.
Findings breakdown (8 total)

1 high / 7 info

Confidence: 85%


🔗 View Full Review Report — detailed findings, severity breakdown, and agent analysis

Reviewed by Looks Good To Meow — AI-powered code review


💬 You can interact with me directly in this PR:

  • @tarin-lgtm fix [any constraints]
  • @tarin-lgtm explain [your question]
  • @tarin-lgtm improve [focus area]
  • @tarin-lgtm test [what to focus on]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GOOD FIRST ISSUE] : Excessive vertical spacing between homepage sections

1 participant