Fix Prezto module loading order#87
Open
brandon-fryslie wants to merge 3 commits intotarjoilija:masterfrom
Open
Fix Prezto module loading order#87brandon-fryslie wants to merge 3 commits intotarjoilija:masterfrom
brandon-fryslie wants to merge 3 commits intotarjoilija:masterfrom
Conversation
…rlier-declared plugins
|
Thanks for the fix. This fixed issues where prezto default modules were overwriting my other plugins! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a relatively simple and succinct way to fix the module loading order problem.
Note that this will only work if
zgen preztois first in the list of commands, but if people put other modules first they are probably asking for trouble anyway.Another issue is that I don't particularly like matching on the specific string 'prezto-master/init.zsh', but that seems unlikely to change, and if it does its a simple fix to change it to the correct name.
This does fix the module loading order problem by making sure all prezto modules are loaded before any other plugins that may depend on them, without overwriting functions and aliases set in other plugins.