This repository was archived by the owner on Sep 17, 2018. It is now read-only.
Changed Wikihouse Plugin to be compatible with Sketchup Extensions.#3
Open
MrKriss wants to merge 28 commits intotav:masterfrom
Open
Changed Wikihouse Plugin to be compatible with Sketchup Extensions.#3MrKriss wants to merge 28 commits intotav:masterfrom
MrKriss wants to merge 28 commits intotav:masterfrom
Conversation
short script to add the plugin as a SketchUp Extension. Also updated README install instructions.
make release should upload following to Amazon S3
bucket: wikihouse_extension.rbz and wikihouse_extension-{git-rev}.rbz
Included .gitignore for .rbz files.
Renamed all instances of plugin to extension for clarity.
Updated install instruction in README
namespace recalling between different files of ruby code. Beginning to split up wikihouse.rb into smaller files of related code. Run flags and config constants now in wikihouse_extension_loader before extension is loaded. Extra constants now in constants.rb Utility functions and classes now in utils.rb Output writters now in writers.rb SVG output currently has an error. Investigating.
Author
|
Hi Tav, whats the status of this? And should I continue to submit more work to this same pull request or wait till you are done with this one? I'm currently working on my own Dev branch of the folk. |
Collaborator
|
/me pokes @tav |
Owner
|
Hey @MrKriss, haven't forgotten you... just been busy with my upcoming wedding in 2 weeks! 😃 Will review and merge it soonish. As for other work you are doing, it would be great if you could break it down into individual pull requests per feature. Thanks! |
with "install_mac"
object strings. Used in parsing data to web dialogues.
wikihouse_extension_loader.rb
'@@wikihouse_settings' to store variable info.
These will update all files in necessary plugin folders. Note folders must already exist.
check in SU 2013 that was throwing an error on loading plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main additions:
makeormake buildnow generateswikihouse_extension.rbzmake releaseshould upload following to Amazon S3 bucket:wikihouse_extension.rbzandwikihouse_extension-{git-rev}.rbz.gitignorefor .rbz files