fix: fail init when storage bucket does not exist#22
Merged
Conversation
Previously, `claude-sync init` would print a warning when the bucket didn't exist but still report "Setup complete!", leading to a confusing error on the subsequent `push`. Now init fails with an actionable error message including links to create the bucket. Also fixes BucketExists in all three storage backends (R2, S3, GCS) to properly distinguish "bucket not found" from other errors (auth failures, network issues) instead of silently swallowing all errors. Closes #21
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BucketExistsin R2/S3/GCS backends now properly distinguishes "not found" from other errors (auth failures, network issues) using typed error checksBucketExistserror propagation behaviorCloses #21