Updated db_connection to v2 #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstuarttaxfix
requested review from
a team,
alexdeleon,
liveforeverx and
tgrk
liveforeverx
approved these changes
May 27, 2020
Contributor
liveforeverx
left a comment
liveforeverx
left a comment
There was a problem hiding this comment.
Looks good to me! Just some Nits comments/questions.
lib/grakn.ex
Outdated
| @spec query(conn(), Grakn.Query.t(), Keyword.t()) :: any() | ||
| def query(conn, query, opts \\ []) do | ||
| DBConnection.execute(get_conn(conn), query, [], with_transaction_config(opts)) | ||
| |> case do |
Contributor
There was a problem hiding this comment.
Really Nit:
What do you think about this style thing https://github.com/lexmag/elixir-style-guide#needless-pipeline ?
Contributor
There was a problem hiding this comment.
This is actually a case for with:
with {:ok, _query, result} <-
DBConnection.execute(get_conn(conn), query, [], with_transaction_config(opts)) do
{:ok, result}
end
lib/grakn.ex
Outdated
| @spec query!(conn(), Grakn.Query.t(), Keyword.t()) :: any() | ||
| def query!(conn, %Grakn.Query{} = query, opts \\ []) do | ||
| DBConnection.execute!(get_conn(conn), query, [], with_transaction_config(opts)) | ||
| |> case do |
Contributor
There was a problem hiding this comment.
The same Nit question here :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase currently uses db_connection v1, which in itself uses Ecto 2. As a result of this, applications that rely on this library cannot upgrade to Ecto 3. This PR updates the codebase to use db_connection v2. The API to external clients stays the same as previously expected.